refactor: codereview feedback

openshift · Feb 15, 2024 · 5526179 · 5526179
1 parent 0834d8f
commit 5526179
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/controller/periodic/job.go b/pkg/controller/periodic/job.go
@@ -128,8 +128,8 @@ func (j *JobController) WaitForJobCompletion(ctx context.Context, jobName string
 				continue
 			}
 
-			job, fail := event.Object.(*batchv1.Job)
-			if job == nil || fail {
+			job, ok := event.Object.(*batchv1.Job)
+			if !ok {
 				return fmt.Errorf("failed to cast job event: %v", event.Object)
 			}
 			if job.Status.Succeeded > 0 {