Merge pull request #306 from rluders/parallelism-testing

Introduce parallelism to unit tests
openshift · Feb 12, 2021 · e43b41e · e43b41e
2 parents 20612a8 + a5d2e07
commit e43b41e
Show file tree

Hide file tree

Showing 10 changed files with 22 additions and 1 deletion.
diff --git a/pkg/authorizer/clusterauthorizer/clusterauthorizer_test.go b/pkg/authorizer/clusterauthorizer/clusterauthorizer_test.go
@@ -19,7 +19,6 @@ func nonCachedProxyFromEnvironment() func(*http.Request) (*url.URL, error) {
 	}
 }
 
-
 func TestProxy(tt *testing.T) {
 	testCases := []struct {
 		Name       string
@@ -85,6 +84,7 @@ func TestProxy(tt *testing.T) {
 	for _, tcase := range testCases {
 		tc := tcase
 		tt.Run(tc.Name, func(t *testing.T) {
+			// do not use parallel here
 			for k, v := range tc.EnvValues {
 				defer SafeRestoreEnv(k)()
 				// nil will indicate the need to unset Env

diff --git a/pkg/config/configobserver/configobserver_test.go b/pkg/config/configobserver/configobserver_test.go
@@ -59,7 +59,9 @@ func TestChangeSupportConfig(t *testing.T) {
 	}
 
 	for _, tt := range cases {
+		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
 
 			// log klog to test
 			klog.SetOutput(utils.NewTestLog(t).Writer())

diff --git a/pkg/controller/status/status_test.go b/pkg/controller/status/status_test.go
@@ -65,7 +65,9 @@ func TestSaveInitialStart(t *testing.T) {
 	}
 
 	for _, tt := range tests {
+		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
 
 			klog.SetOutput(utils.NewTestLog(t).Writer())
 			operators := []runtime.Object{}

diff --git a/pkg/gather/clusterconfig/0_gahterer_test.go b/pkg/gather/clusterconfig/0_gahterer_test.go
@@ -163,7 +163,9 @@ func Test_uniqueStrings(t *testing.T) {
 		{arr: []string{"a"}, want: []string{"a"}},
 	}
 	for _, tt := range tests {
+		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
 			if got := uniqueStrings(tt.arr); !reflect.DeepEqual(got, tt.want) {
 				t.Errorf("uniqueStrings() = %v, want %v", got, tt.want)
 			}

diff --git a/pkg/gather/clusterconfig/certificate_signing_requests_test.go b/pkg/gather/clusterconfig/certificate_signing_requests_test.go
@@ -22,7 +22,9 @@ func TestCSRs(t *testing.T) {
 	}
 
 	for _, tt := range files {
+		tt := tt
 		t.Run(tt.dataFile, func(t *testing.T) {
+			t.Parallel()
 
 			r := &certificatesv1api.CertificateSigningRequest{}
 
@@ -84,7 +86,10 @@ func TestCSRFilters(t *testing.T) {
 
 	for i, tt := range files {
 		n := csrName(tt.csr, fmt.Sprintf("[n/a:%d]", i))
+		tt := tt
 		t.Run(n, func(t *testing.T) {
+			t.Parallel()
+
 			now, err := time.Parse("Mon Jan 02 2006 15:04:05 GMT-0700 (MST)", "Tue Feb 18 2020 09:38:42 GMT+0100 (CEST)")
 			if err != nil {
 				t.Fatalf("parse couldnt parse date %v", err)

diff --git a/pkg/gather/clusterconfig/config_maps_test.go b/pkg/gather/clusterconfig/config_maps_test.go
@@ -47,7 +47,9 @@ func TestConfigMapAnonymizer(t *testing.T) {
 	}
 
 	for _, tt := range cases {
+		tt := tt
 		t.Run(tt.testName, func(t *testing.T) {
+			t.Parallel()
 			f, err := os.Open("testdata/configmaps.json")
 			mustNotFail(t, err, "error opening test data file. %+v")
 			defer f.Close()

diff --git a/pkg/gather/clusterconfig/image_pruners_test.go b/pkg/gather/clusterconfig/image_pruners_test.go
@@ -49,7 +49,9 @@ func TestGatherClusterPruner(t *testing.T) {
 		},
 	}
 	for _, test := range tests {
+		test := test
 		t.Run(test.name, func(t *testing.T) {
+			t.Parallel()
 			client := imageregistryfake.NewSimpleClientset(test.inputObj)
 			ctx := context.Background()
 			records, errs := gatherClusterImagePruner(ctx, client.ImageregistryV1())

diff --git a/pkg/gather/clusterconfig/image_registries_test.go b/pkg/gather/clusterconfig/image_registries_test.go
@@ -120,7 +120,9 @@ func TestGatherClusterImageRegistry(t *testing.T) {
 		},
 	}
 	for _, test := range tests {
+		test := test
 		t.Run(test.name, func(t *testing.T) {
+			t.Parallel()
 			client := imageregistryfake.NewSimpleClientset(test.inputObj)
 			coreClient := kubefake.NewSimpleClientset()
 			ctx := context.Background()

diff --git a/pkg/gather/clusterconfig/install_plans_test.go b/pkg/gather/clusterconfig/install_plans_test.go
@@ -50,7 +50,9 @@ func TestGatherInstallPlans(t *testing.T) {
 	}
 
 	for _, test := range tests {
+		test := test
 		t.Run(test.name, func(t *testing.T) {
+			t.Parallel()
 
 			var client *dynamicfake.FakeDynamicClient
 			coreClient := kubefake.NewSimpleClientset()

diff --git a/pkg/gather/clusterconfig/service_accounts_test.go b/pkg/gather/clusterconfig/service_accounts_test.go
@@ -47,7 +47,9 @@ func TestGatherServiceAccounts(t *testing.T) {
 	}
 
 	for _, test := range tests {
+		test := test
 		t.Run(test.name, func(t *testing.T) {
+			t.Parallel()
 			coreClient := kubefake.NewSimpleClientset()
 			for _, d := range test.data {
 				_, err := coreClient.CoreV1().Namespaces().Create(context.Background(), &corev1.Namespace{ObjectMeta: metav1.ObjectMeta{Name: d.Namespace}}, metav1.CreateOptions{})