Bug 1860921: [release-4.6] Bug 1860921: Check also Pod status before enabling Fast upload

[martinkunc]

There are three main changes here:

• Besides checking reported operator status, before enabling Fast upload path (without initial delay) it is also checking insights Operator Pod status. This is to address Bug 1841057: Skip the initial upload delay #117 (comment).
• Originally, the fast upload mode was enabled and disabled by UpdateStatus, which is happening on startup and then periodically every 30s. On larger clusters when data Gathering took more then 30 seconds, this consequent call to updateStatus was not considered initial and disabled - even if operator was helthy. To fix this, fast mode is now disabled from after insights upload happens (successfully or not)..
• Additional fast upload mode improvement - originally when Cluster Version wasnt available (which is collected during Gather) upload sets waiting time to random interval 0 - 15m, which could slow down initial fast upload. To fix this, when we are in fast upload mode, it is now waiting only 15 sec (to wait for Gather to finish).

[martinkunc]

/test insights-operator-e2e-tests

[martinkunc]

/test e2e-aws
/test insights-operator-e2e-tests

[tisnik]

It looks good, thank you @martinkunc

[tisnik]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: martinkunc, tisnik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [martinkunc,tisnik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-cherrypick-robot]

@martinkunc: #132 failed to apply on top of branch "release-4.2":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	pkg/controller/operator.go
M	pkg/controller/status/status.go
M	pkg/insights/insightsuploader/insightsuploader.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/insights/insightsuploader/insightsuploader.go
CONFLICT (content): Merge conflict in pkg/insights/insightsuploader/insightsuploader.go
Auto-merging pkg/controller/status/status.go
CONFLICT (content): Merge conflict in pkg/controller/status/status.go
Auto-merging pkg/controller/operator.go
Patch failed at 0001 Check also Pod status before enabling Fast upload. Fast status is now disabled only after upload.

In response to this:

/cherrypick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[martinkunc]

/cherrypick release-4.5

[openshift-cherrypick-robot]

@martinkunc: new pull request created: #139

In response to this:

/cherrypick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[martinkunc]

/retitle Bug 1860921: [release-4.6] Bug 1860921: Check also Pod status before enabling Fast upload

[openshift-ci-robot]

@martinkunc: All pull requests linked via external trackers have merged: . Bugzilla bug 1860921 has been moved to the MODIFIED state.

In response to this:

Bug 1860921: [release-4.6] Bug 1860921: Check also Pod status before enabling Fast upload

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.