TestCSRCollected #155
TestCSRCollected #155
Conversation
| clientset.CertificatesV1beta1().CertificateSigningRequests().Delete(name, &metav1.DeleteOptions{}) | ||
| restartInsightsOperator(t) | ||
| }() | ||
| defer ChangeReportTimeInterval(t, 1)() |
There was a problem hiding this comment.
why do we need to change report time interval after the test? It wasn't changed during the test
There was a problem hiding this comment.
ChangeReportTimeInterval returns callback function which reverts the changes. The report time interval is changed on this line, only callback function is defered. It's equivalent to:
revertReportTimeInterval := ChangeReportTimeInterval(t, 1)
defer revertReportTimeInterval()
|
lgtm |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: martinkunc, psimovec The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1835090
Q: Is checking if CSR is collected enough? or we also need to check if the collected CSR is anonymized?