Bug 1873101: Gather VolumeSnapshot CRD #166
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
approved
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
natiiix
force-pushed
the
volumesnapshot
branch
from
4342d5d
to
85509a1
Compare
|
Okay, it won't work without including the vendoring of the K8s API extensions module. |
|
/retest |
|
/retitle Bug 1873101: Gather VolumeSnapshot CRD |
openshift-ci-robot
changed the title
openshift-ci-robot
added
bugzilla/severity-medium
|
@natiiix: This pull request references Bugzilla bug 1873101, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@natiiix: This pull request references Bugzilla bug 1873101, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
1 similar comment
|
/retest |
|
/test e2e-aws |
|
/retest |
1 similar comment
|
/retest |
| // Location in archive: config/crd/ | ||
| func GatherCRD(i *Gatherer) func() ([]record.Record, []error) { | ||
| return func() ([]record.Record, []error) { | ||
| crds, err := i.crdClient.CustomResourceDefinitions().List(metav1.ListOptions{}) |
There was a problem hiding this comment.
Would it be possible to instead of getting whole List, just get concrete CRD by Name ? It could be a bit more efficient I think.
Maybe something like:
crds := []string{"one","two"}
for _, c := range crds {
i.crdClient.CustomResourceDefinitions().Get(c,metav1.ListOptions{})
//... append
}
There was a problem hiding this comment.
Oh, thanks for pointing this out, I totally didn't realize we could do this.
natiiix
force-pushed
the
volumesnapshot
branch
from
89ecf30
to
eb0bd60
Compare
|
/lgtm Thank you, very nice :) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: martinkunc, natiiix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@natiiix: All pull requests linked via external trackers have merged: Bugzilla bug 1873101 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@natiiix It looks the CRDs for volume snapshots are missing on 4.3 we would need to skip missing CRD gracefully and continue collection. |
Jira: CCXDEV-2393
Perhaps the vendoring of K8s API Extensions module commit will go into a separate PR, but I included it for now for the sake of completeness.That does not seem to be possible since all the tests fail without the vendoring.