Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1888172: Updates the sample archive. #220

Merged
merged 2 commits into from
Oct 20, 2020

Conversation

0sewa0
Copy link
Contributor

@0sewa0 0sewa0 commented Oct 14, 2020

#209 didn't update the sample archive, but machineset and pdbs are now namespaced

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2020
@0sewa0 0sewa0 changed the title Updates the sample archive. Bug 1888172: Updates the sample archive. Oct 14, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 14, 2020
@openshift-ci-robot
Copy link
Contributor

@0sewa0: This pull request references Bugzilla bug 1888172, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1888172: Updates the sample archive.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes
Copy link
Contributor

tremes commented Oct 14, 2020

OK. We should probably start using json formatting in the sample archive. I know it's very likely mixed now, but still....

@openshift-ci-robot
Copy link
Contributor

@0sewa0: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/insights-operator-e2e-tests 21bf752 link /test insights-operator-e2e-tests
ci/prow/e2e-aws 21bf752 link /test e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@martinkunc
Copy link
Contributor

/test e2e-aws
/test insights-operator-e2e-tests

@martinkunc
Copy link
Contributor

Actually, Tomas had a good point and it is not that hard.
@0sewa0 Could you please look into the formatting archive json files If you execute the command in your docs folder, it should reformat the files which are not.

@0sewa0
Copy link
Contributor Author

0sewa0 commented Oct 20, 2020

/retest

@tremes
Copy link
Contributor

tremes commented Oct 20, 2020

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0sewa0, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2020
@openshift-merge-robot openshift-merge-robot merged commit 2c0a428 into openshift:master Oct 20, 2020
@openshift-ci-robot
Copy link
Contributor

@0sewa0: All pull requests linked via external trackers have merged:

Bugzilla bug 1888172 has been moved to the MODIFIED state.

In response to this:

Bug 1888172: Updates the sample archive.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants