Bug 1934112: Adds memory usage to the metadata

[0sewa0]

This PR adds 2 new fields to the metadata (gathers.json).
uptime: the duration since the start of the first gather
memory_alloc: the memory allocated at the time of creating the report. (in bytes)

Some disclaimers:

• I intended to have memory usage stats for each gather-function, but it wasn't really viable. The only way I could measure it was by marshaling the produced records, which is not only inefficient but we can just as easily measure the size of the produced archive and get the same idea.
• The memory_alloc stat wont show the peak memory allocation. Even if we are only talking about the gather cycle, knowing when to measure to get the max usage is impossible so we would need to monitor the entire process, which would more complex without much benefit IMO. The purpose of this field is to be able to notice if over a long period there might be a memory leak.

Categories

• Bugfix
• Enhancement
• Backporting
• Others (CI, Infrastructure, Documentation)

Sample archive

• docs/insights-archive-sample/insights-operator/gathers.json

Documentation

• none

Unit Tests

• none

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

References

none

[openshift-ci-robot]

@0sewa0: This pull request references Bugzilla bug 1934112, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.8.0) matches configured target release for branch (4.8.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1934112: Adds memory usage to the metadata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tremes]

I tried it locally and the code change looks good to me as well. Maybe we could do the uptime in the minutes, but it's very minor detail.
/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0sewa0, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [0sewa0,tremes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[0sewa0]

/retest

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@0sewa0: All pull requests linked via external trackers have merged:

• openshift/insights-operator#356

Bugzilla bug 1934112 has been moved to the MODIFIED state.

In response to this:

Bug 1934112: Adds memory usage to the metadata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.