[release 4.6] Bug 1942457: Adds metadata to the IO archive

[0sewa0]

This PR is a backport of #364
It introduces the metadata gathering to 4.6 and the recently added 2 new fields. (gathers.json).

Info about each gather-function:

• name
• duration in milliseconds
• the count of records collected
• errors (if any)

Info about the whole gather process:

• uptime_seconds: the duration since the start of the first record.Collect
• memory_alloc_bytes: the memory allocated at the time of creating the report. (in bytes)

Some disclaimers:

I intended to have memory usage stats for each gather-function, but it wasn't really viable. The only way I could measure it was by marshaling the produced records, which is not only inefficient but we can just as easily measure the size of the produced archive and get the same idea.
The memory_alloc stat wont show the peak memory allocation. Even if we are only talking about the gather cycle, knowing when to measure to get the max usage is impossible so we would need to monitor the entire process, which would more complex without much benefit IMO. The purpose of this field is to be able to notice if over a long period there might be a memory leak.

Categories

• Bugfix
• Enhancement
• Backporting
• Others (CI, Infrastructure, Documentation)

Sample archive

• see docs/insights-archive-sample/insights-operator/gathers.json

Documentation

• no

Unit Tests

• no

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

References

https://bugzilla.redhat.com/show_bug.cgi?id=???

[openshift-ci-robot]

@0sewa0: This pull request references Bugzilla bug 1942457, which is invalid:

• expected dependent Bugzilla bug 1935605 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead
• expected dependent Bugzilla bug 1934112 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release 4.6] Bug 1942457: Adds metadata to the IO archive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@0sewa0: This pull request references Bugzilla bug 1942457, which is invalid:

• expected dependent Bugzilla bug 1935605 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead
• expected dependent Bugzilla bug 1934112 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release 4.6] Bug 1942457: Adds metadata to the IO archive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@0sewa0: This pull request references Bugzilla bug 1942457, which is invalid:

• expected dependent Bugzilla bug 1935605 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead
• expected dependent Bugzilla bug 1934112 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release 4.6] Bug 1942457: Adds metadata to the IO archive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tremes]

/bugzilla refresh

[openshift-ci-robot]

@tremes: This pull request references Bugzilla bug 1942457, which is invalid:

• expected dependent Bugzilla bug 1934112 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[0sewa0]

/bugzilla refresh

[openshift-ci-robot]

@0sewa0: This pull request references Bugzilla bug 1942457, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.z) matches configured target release for branch (4.6.z)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1935605 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 1935605 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
• bug has dependents

Requesting review from QA contact:
/cc @psimovec

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[0sewa0]

/retest

[tremes]

Executed locally and works as expected.
/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0sewa0, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [0sewa0,tremes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tremes]

/retest

[openshift-ci-robot]

@0sewa0: All pull requests linked via external trackers have merged:

• openshift/insights-operator#382

Bugzilla bug 1942457 has been moved to the MODIFIED state.

In response to this:

[release 4.6] Bug 1942457: Adds metadata to the IO archive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.