Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1948966: One-off gather #389

Merged
merged 6 commits into from
Apr 13, 2021

Conversation

0sewa0
Copy link
Contributor

@0sewa0 0sewa0 commented Apr 7, 2021

Updates the gather_job.go so that it doesn't always require a --kubeconfig param, also adds the docs/gather-job.yaml which is a one off job to run a single gather.

# Create Job
$ kubectl apply -n openshift-insights -f docs/gather-job.yaml
...


# Get Job's pod's name
$ kubectl describe -n openshift-insights job/insights-operator-job
...
Events:
  Type    Reason            Age    From            Message
  ----    ------            ----   ----            -------
  Normal  SuccessfulCreate  7m18s  job-controller  Created pod: insights-operator-job-zhmrd <-- THIS


# Check if the gather finished (optional)
$ kubectl logs -n openshift-insights insights-operator-job-zhmrd insights-operator
...
I0407 11:55:38.192084       1 diskrecorder.go:34] Wrote 108 records to disk in 33ms <-- THIS


# Get the archives
$ kubectl cp openshift-insights/insights-operator-job-zhmrd:/var/lib/insights-operator ./insights-data
...


# Cleanup
$ kubectl delete -n openshift-insights job insights-operator-job
...

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample archive

  • nope

Documentation

  • TODO

Unit Tests

  • nope

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

References

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2021
@openshift-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2021
docs/gather-job.yaml Outdated Show resolved Hide resolved
docs/gather-job.yaml Outdated Show resolved Hide resolved
@0sewa0 0sewa0 marked this pull request as ready for review April 8, 2021 08:34
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 8, 2021
pkg/cmd/start/start.go Show resolved Hide resolved
@0sewa0
Copy link
Contributor Author

0sewa0 commented Apr 12, 2021

/retest

- --config=/etc/insights-operator/server.yaml
containers:
- name: sleepy
image: busybox
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this image available in the cluster registry or does it need to be downloaded? I guess the latter one....and that would be a bit problematic in an air-gapped cluster.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be worth mentioning it in the docs for air-gaped users, but I don't know any simpler way to run anything on openshift :/

Copy link
Contributor

@quarckster quarckster May 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really could be problematic and cause errors because docker hub has a limitation on anonymous pulls. The safest way would be using the same quay.io/openshift/origin-insights-operator image.

@0sewa0
Copy link
Contributor Author

0sewa0 commented Apr 13, 2021

/retest

@0sewa0 0sewa0 changed the title One-off gather Bug 1948966: One-off gather Apr 13, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 13, 2021
@openshift-ci-robot
Copy link
Contributor

@0sewa0: This pull request references Bugzilla bug 1948966, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @psimovec

In response to this:

Bug 1948966: One-off gather

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0sewa0, rluders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit aa77ccf into openshift:master Apr 13, 2021
@openshift-ci-robot
Copy link
Contributor

@0sewa0: All pull requests linked via external trackers have merged:

Bugzilla bug 1948966 has been moved to the MODIFIED state.

In response to this:

Bug 1948966: One-off gather

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants