-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1948966: One-off gather #389
Conversation
Skipping CI for Draft Pull Request. |
/retest |
- --config=/etc/insights-operator/server.yaml | ||
containers: | ||
- name: sleepy | ||
image: busybox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this image available in the cluster registry or does it need to be downloaded? I guess the latter one....and that would be a bit problematic in an air-gapped cluster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might be worth mentioning it in the docs for air-gaped users, but I don't know any simpler way to run anything on openshift :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This really could be problematic and cause errors because docker hub has a limitation on anonymous pulls. The safest way would be using the same quay.io/openshift/origin-insights-operator
image.
/retest |
@0sewa0: This pull request references Bugzilla bug 1948966, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0sewa0, rluders The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@0sewa0: All pull requests linked via external trackers have merged: Bugzilla bug 1948966 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Updates the gather_job.go so that it doesn't always require a
--kubeconfig
param, also adds thedocs/gather-job.yaml
which is a one off job to run a single gather.Categories
Sample archive
Documentation
Unit Tests
Privacy
Yes. There are no sensitive data in the newly collected information.
Changelog
References