Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1948311: DelegatingAuthenticationOptions TokenReview request timeout #406

Merged
merged 2 commits into from
Apr 22, 2021

Conversation

p0lyn0mial
Copy link
Contributor

This repository uses the delegated authentication which has been identified to contain a bug that increases the number of watch requests against the Kube API server.

We provided a temporary branch that contains a fix and switched this repository to that branch.

With this change, k8s.io/apiserver points to temporary-watch-reduction-patch-1.21 to pick up k/k/pull/101102

Feel free to remove it once the upstream PR merges and a new Z release is cut.

Categories

  • Bugfix
  • [] Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample archive

  • path/to/sample_data.json

Documentation

  • path/to/documentation.md

Unit Tests

  • path/to/file_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

References

https://issues.redhat.com/browse/???
https://bugzilla.redhat.com/show_bug.cgi?id=???
https://access.redhat.com/solutions/???

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Apr 21, 2021
@openshift-ci-robot
Copy link
Contributor

@p0lyn0mial: This pull request references Bugzilla bug 1948311, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

Bug 1948311: DelegatingAuthenticationOptions TokenReview request timeout

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 21, 2021
@p0lyn0mial
Copy link
Contributor Author

/cc @deads2k

@p0lyn0mial
Copy link
Contributor Author

/retest

1 similar comment
@tremes
Copy link
Contributor

tremes commented Apr 22, 2021

/retest

@tremes
Copy link
Contributor

tremes commented Apr 22, 2021

@p0lyn0mial Can you please link the URL to the k/k/pull/101102 ?

@tremes
Copy link
Contributor

tremes commented Apr 22, 2021

OK this one kubernetes/kubernetes#101102 right. I guess we will need to wait for k8s.io/apiserver v0.22.0 to be able to remove the temporary fix right.

@p0lyn0mial
Copy link
Contributor Author

OK this one kubernetes/kubernetes#101102 right.

correct

I guess we will need to wait for k8s.io/apiserver v0.22.0 to be able to remove the temporary fix right.

no, for 1.21.1

@tremes
Copy link
Contributor

tremes commented Apr 22, 2021

Ohh these versions...OK :) Thanks.
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6433cde into openshift:master Apr 22, 2021
@openshift-ci-robot
Copy link
Contributor

@p0lyn0mial: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1948311 has not been moved to the MODIFIED state.

In response to this:

Bug 1948311: DelegatingAuthenticationOptions TokenReview request timeout

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants