Bug 1955102: Add vsphere_node_hw_version_total metric to the collected metrics

[0sewa0]

Add vsphere_node_hw_version_total metric to the collected metrics

Categories

• Bugfix
• Enhancement
• Backporting
• Others (CI, Infrastructure, Documentation)

Sample archive

• docs/insights-archive-sample/config/metrics was updated

Documentation

• docs/gathered-data.md was updated

Unit Tests

• not necessary

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

References

https://issues.redhat.com/browse/CCXDEV-4623

[openshift-ci-robot]

@0sewa0: This pull request references Bugzilla bug 1955102, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.8.0) matches configured target release for branch (4.8.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @psimovec

In response to this:

Bug 1955102: Add vsphere_node_hw_version_total metric to the collected metrics

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@0sewa0: This pull request references Bugzilla bug 1955102, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.8.0) matches configured target release for branch (4.8.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @psimovec

In response to this:

Bug 1955102: Add vsphere_node_hw_version_total metric to the collected metrics

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tremes]

Simple change and we tested it locally.
/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0sewa0, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [0sewa0,tremes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tremes]

Let me try
/cherrypick release-4.7

[openshift-cherrypick-robot]

@tremes: once the present PR merges, I will cherry-pick it on top of release-4.7 in a new PR and assign it to you.

In response to this:

Let me try
/cherrypick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@0sewa0: All pull requests linked via external trackers have merged:

• openshift/insights-operator#414

Bugzilla bug 1955102 has been moved to the MODIFIED state.

In response to this:

Bug 1955102: Add vsphere_node_hw_version_total metric to the collected metrics

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@tremes: #414 failed to apply on top of branch "release-4.7":

Applying: Add vsphere_node_hw_version_total metric to the collected metrics
Using index info to reconstruct a base tree...
M	pkg/gather/clusterconfig/recent_metrics.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/gather/clusterconfig/recent_metrics.go
Applying: Update docs
Applying: Updated the sample archive
Using index info to reconstruct a base tree...
M	docs/insights-archive-sample/config/metrics
Falling back to patching base and 3-way merge...
Auto-merging docs/insights-archive-sample/config/metrics
CONFLICT (content): Merge conflict in docs/insights-archive-sample/config/metrics
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 Updated the sample archive
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

Let me try
/cherrypick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.