Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1958790: Store translation table in a secret #419

Merged
merged 8 commits into from
Jun 8, 2021
Merged

Bug 1958790: Store translation table in a secret #419

merged 8 commits into from
Jun 8, 2021

Conversation

0sewa0
Copy link
Contributor

@0sewa0 0sewa0 commented May 5, 2021 •
edited
Loading

The anonymizer has a translation-table about the obfuscated IP addresses. As of right now its inaccessible, so this change would store the translation-table in a Secret in the openshift-insights namespace.
On the Web UI you can easily find the secrets under Workloads -> Secrets, the name of the secret is obfuscation-translation-table.

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample archive

  • no

Documentation

  • Added docstrings, user facing documentation is a separate task.

Unit Tests

  • Added new unit tests to pkg/anonymization/anonymizer_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

References

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2021
@openshift-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0sewa0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2021
@Serhii1011010
Copy link
Contributor

Looks great, would be fine to have a simple test of the behaviour, but up to you

@0sewa0 0sewa0 changed the title Store translation table in a secret Bug 1958790: Store translation table in a secret May 10, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label May 10, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 10, 2021

@0sewa0: This pull request references Bugzilla bug 1958790, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @psimovec

In response to this:

Bug 1958790: Store translation table in a secret

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 10, 2021
@0sewa0 0sewa0 marked this pull request as ready for review May 10, 2021 07:29
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2021
@0sewa0
Copy link
Contributor Author

0sewa0 commented May 10, 2021

/retest

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2021
@0sewa0
Copy link
Contributor Author

0sewa0 commented May 17, 2021

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented May 17, 2021

@0sewa0: This pull request references Bugzilla bug 1958790, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @psimovec

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@0sewa0
Copy link
Contributor Author

0sewa0 commented May 17, 2021

/retest

@Serhii1011010
Copy link
Contributor

Serhii1011010 commented May 19, 2021 •
edited
Loading

Just tested and it doesn't work anymore

E0519 10:34:25.607470   13606 anonymizer.go:296] Failed to create the translation table secret. err: secrets is forbidden: User "system:serviceaccount:openshift-insights:gather" cannot create resource "secrets" in API group "" in the namespace "openshift-insights"

Looks like it's because of this change #424 which makes obfuscation initialize using gather serviceaccount instead of operator. So looks like you need to create secret client from a different kubeconfig from pkg/controller/gather_job.go and pkg/controller/operator.go, the one with operator service account (either kubeClient or configClient https://github.com/Sergey1011010/insights-operator/blob/e1f148e87fd3e457950f62b3f407cde509564dee/pkg/controller/operator.go#L57)

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

24 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@0sewa0
Copy link
Contributor Author

0sewa0 commented Jun 8, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 110522d into openshift:master Jun 8, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2021

@0sewa0: All pull requests linked via external trackers have merged:

Bugzilla bug 1958790 has been moved to the MODIFIED state.

In response to this:

Bug 1958790: Store translation table in a secret

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Serhii1011010 Serhii1011010 Serhii1011010 left review comments

@tremes tremes tremes left review comments

@psimovec psimovec Awaiting requested review from psimovec

Assignees

@tremes tremes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@0sewa0 @openshift-ci-robot @Serhii1011010 @tremes @openshift-bot @openshift-merge-robot