-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1961091: Adding GatherMachineHealthCheck #429
Bug 1961091: Adding GatherMachineHealthCheck #429
Conversation
Skipping CI for Draft Pull Request. |
@rluders: An error was encountered querying GitHub for users with public email (psimovec@redhat.com) for bug 1961091 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#abuse-rate-limits\",\n \"message\": \"You have triggered an abuse detection mechanism. Please wait a few minutes before you try again.\"\n}\n"
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This adds the machinehealthcheck gathering with dynamic client. Documentation and testing
17faa6e
to
e615ba3
Compare
@rluders: This pull request references Bugzilla bug 1961091, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
other then the weird stuff in the |
@0sewa0 done, removed all the missing entries. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0sewa0, rluders The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rluders: All pull requests linked via external trackers have merged: Bugzilla bug 1961091 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR implements a new data enhancement to gather
machinehealthcheck
.Categories
Sample Archive
docs/insights-archive-sample/config/machinehealthchecks/openshift-machine-api/machine-api-termination-handler.json
Documentation
docs/gathered-data.md
Unit Tests
pkg/gatherers/clusterconfig/machine_healthcheck_test.go
Privacy
Yes. There are no sensitive data in the newly collected information.
Changelog
Breaking Changes
No
References
https://issues.redhat.com/browse/CCXDEV-4633
https://bugzilla.redhat.com/show_bug.cgi?id=1961091