Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1961091: Adding GatherMachineHealthCheck #429

Conversation

rluders
Copy link
Contributor

@rluders rluders commented May 17, 2021

This PR implements a new data enhancement to gather machinehealthcheck.

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/machinehealthchecks/openshift-machine-api/machine-api-termination-handler.json

Documentation

  • docs/gathered-data.md

Unit Tests

  • pkg/gatherers/clusterconfig/machine_healthcheck_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-4633
https://bugzilla.redhat.com/show_bug.cgi?id=1961091

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 17, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot requested review from 0sewa0 and mfojtik May 17, 2021 08:49
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 17, 2021

@rluders: An error was encountered querying GitHub for users with public email (psimovec@redhat.com) for bug 1961091 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#abuse-rate-limits\",\n \"message\": \"You have triggered an abuse detection mechanism. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1961091: Adding GatherMachineHealthCheck

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This adds the machinehealthcheck gathering with dynamic client.

Documentation and testing
@rluders rluders force-pushed the ccxdev-4633-gather-machinehealthcheck-definitions branch from 17faa6e to e615ba3 Compare May 17, 2021 14:30
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label May 17, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 17, 2021

@rluders: This pull request references Bugzilla bug 1961091, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @psimovec

In response to this:

Bug 1961091: Adding GatherMachineHealthCheck

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 17, 2021
@openshift-ci openshift-ci bot requested a review from psimovec May 17, 2021 14:31
@rluders rluders marked this pull request as ready for review May 17, 2021 14:31
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2021
docs/gathered-data.md Outdated Show resolved Hide resolved
docs/gathered-data.md Outdated Show resolved Hide resolved
docs/gathered-data.md Outdated Show resolved Hide resolved
docs/gathered-data.md Outdated Show resolved Hide resolved
docs/gathered-data.md Outdated Show resolved Hide resolved
docs/gathered-data.md Outdated Show resolved Hide resolved
@0sewa0
Copy link
Contributor

0sewa0 commented May 18, 2021

other then the weird stuff in the gathered-data.md, it looks good

@rluders rluders requested a review from 0sewa0 May 18, 2021 07:40
@rluders
Copy link
Contributor Author

rluders commented May 18, 2021

@0sewa0 done, removed all the missing entries.

@0sewa0
Copy link
Contributor

0sewa0 commented May 18, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0sewa0, rluders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5f22ede into openshift:master May 18, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 18, 2021

@rluders: All pull requests linked via external trackers have merged:

Bugzilla bug 1961091 has been moved to the MODIFIED state.

In response to this:

Bug 1961091: Adding GatherMachineHealthCheck

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants