Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1969525: Replace golint with revive #448

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Bug 1969525: Replace golint with revive #448

merged 1 commit into from
Jun 8, 2021

Conversation

rluders
Copy link
Contributor

@rluders rluders commented Jun 8, 2021 •
edited
Loading

This PR replaces golint with revive, since golint is deprecated and revive is 6x faster than golint. Also, this PR fixes some linting issues pointed by revive.

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

No.

Documentation

No.

Unit Tests

  • pkg/gatherers/clusterconfig/container_images_test.go

Privacy

N/A

Changelog

N/A

Breaking Changes

No.

References

https://bugzilla.redhat.com/show_bug.cgi?id=1969525

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2021
@rluders rluders marked this pull request as draft June 8, 2021 13:29
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2021
@rluders rluders marked this pull request as ready for review June 8, 2021 13:32
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2021
@rluders rluders changed the title Replace golint with revive Bug 1969525: Replace golint with revive Jun 8, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 8, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2021

@rluders: This pull request references Bugzilla bug 1969525, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @psimovec

In response to this:

Bug 1969525: Replace golint with revive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from psimovec June 8, 2021 14:24
@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2021

@rluders: This pull request references Bugzilla bug 1969525, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @psimovec

In response to this:

Bug 1969525: Replace golint with revive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tremes
tremes reviewed Jun 8, 2021
View reviewed changes
pkg/gather/gather.go Outdated Show resolved Hide resolved
tremes
tremes reviewed Jun 8, 2021
View reviewed changes
pkg/controller/operator.go Outdated Show resolved Hide resolved
tremes
tremes reviewed Jun 8, 2021
View reviewed changes
pkg/controller/gather_job.go Outdated Show resolved Hide resolved
@rluders rluders requested a review from tremes June 8, 2021 14:58
fix: replace golint with revive, adjust comments
67c05e7 
Increase liting timeout

Improve docs

this improves the code documentation

fix misspelling

fix: docs after rebase
@tremes
Copy link
Contributor

tremes commented Jun 8, 2021

Mostly doc updates to satisfy the linter
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rluders, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rluders
Copy link
Contributor Author

rluders commented Jun 8, 2021

/retest

1 similar comment
@rluders
Copy link
Contributor Author

rluders commented Jun 8, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit fbf3ff6 into openshift:master Jun 8, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2021

@rluders: All pull requests linked via external trackers have merged:

Bugzilla bug 1969525 has been moved to the MODIFIED state.

In response to this:

Bug 1969525: Replace golint with revive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@Serhii1011010 Serhii1011010 Awaiting requested review from Serhii1011010

@psimovec psimovec Awaiting requested review from psimovec

@tremes tremes Awaiting requested review from tremes

Assignees

@tremes tremes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rluders @tremes @openshift-bot @openshift-merge-robot