Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.8] Bug 1977754: Gather all MachineConfig definitions (#449) #459

Merged
merged 1 commit into from
Aug 5, 2021
Merged

[release-4.8] Bug 1977754: Gather all MachineConfig definitions (#449) #459

merged 1 commit into from
Aug 5, 2021

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Jun 18, 2021

This changes original SAPMachineConfig gatherer to gather all machineconfigs definitions. We also forgot to call this new gatherer in 4.8 so this is fixing it.

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

New data added to sample archive with:

  • docs/insights-archive-sample/config/machineconfigs/00-master.json
  • docs/insights-archive-sample/config/machineconfigs/00-worker.json
  • docs/insights-archive-sample/config/machineconfigs/01-master-container-runtime.json
  • etc.

Documentation

Updated in:

  • docs/gathered-data.md

Unit Tests

Test already exists. Just minor renaming.

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/???
https://bugzilla.redhat.com/show_bug.cgi?id=???
https://access.redhat.com/solutions/???

@tremes
[release-4.8] Gather all MachineConfig definitions (openshift#449)
a3a2d54 
* Gather all MachineConfig definitions

* Rename the test function
@openshift-ci
Copy link

openshift-ci bot commented Jun 18, 2021

@tremes: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.8] Gather all MachineConfig definitions (#449)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2021
@tremes tremes changed the title [release-4.8] Gather all MachineConfig definitions (#449) [release-4.8] Bug 1977754: Gather all MachineConfig definitions (#449) Jun 30, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jun 30, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 30, 2021

@tremes: This pull request references Bugzilla bug 1977754, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1977753 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1977753 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (dmisharo@redhat.com), skipping review request.

In response to this:

[release-4.8] Bug 1977754: Gather all MachineConfig definitions (#449)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 30, 2021
rluders
rluders approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rluders, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Jul 22, 2021

Re-validating bugzilla status after prow config updates.
/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Jul 22, 2021

@sdodson: This pull request references Bugzilla bug 1977754, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1977753 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1977753 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (dmisharo@redhat.com), skipping review request.

In response to this:

Re-validating bugzilla status after prow config updates.
/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell
Copy link

ecordell commented Aug 4, 2021

[patch-manager] 🚀 Approved for z-stream by score: 0.20

picked

@ecordell ecordell added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 4, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot merged commit bc15362 into openshift:release-4.8 Aug 5, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 5, 2021

@tremes: All pull requests linked via external trackers have merged:

Bugzilla bug 1977754 has been moved to the MODIFIED state.

In response to this:

[release-4.8] Bug 1977754: Gather all MachineConfig definitions (#449)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell
Copy link

ecordell commented Aug 5, 2021

[patch-manager] 🚀 Approved for z-stream by score: 0.20

picked

@tremes tremes deleted the machineconfigs_4.8 branch May 6, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rluders rluders rluders approved these changes

@0sewa0 0sewa0 Awaiting requested review from 0sewa0

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@rluders rluders

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tremes @openshift-bot @sdodson @ecordell @rluders