Update the gather functions to collect data from the system namespaces only #468
Conversation
|
@qinpingli Thanks for the PR. Good catch! I didn't know one can create e.g "openshifta" namespace. The unit tests are failing. Would you like to take a look pls? |
|
@tremes Thanks for the review. Submitted a new commit to fix the unit test error. |
|
@qinpingli Thanks. |
openshift-ci
bot
added
the
approved
|
Reviewed & verified. Thank you! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinpingli, tremes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test insights-operator-e2e-tests |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
IIUC, the gather functions (serviceaccount, installplan and container images) want to collect the resources in the system(openshift) namespaces only. So, we will check if the namespace has prefix
openshift, but the openshift preserved namespace prefixes areopenshift-, kube-per doc [1].[1] https://docs.openshift.com/container-platform/4.7/applications/projects/working-with-projects.html
Categories
Sample Archive
No changes
Documentation
No changes
Unit Tests
No changes
Privacy
No new collected data
Changelog
No
Breaking Changes
No
References
https://docs.openshift.com/container-platform/4.7/applications/projects/working-with-projects.html