Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2017752: Anonymize identity provider attributes in the #520

Merged
merged 2 commits into from
Oct 27, 2021
Merged

Bug 2017752: Anonymize identity provider attributes in the #520

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62474fc
Anonymize identity provider attributes in the
tremes Oct 14, 2021
c48271d
More robust way....
tremes Oct 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions pkg/gatherers/clusterconfig/operators.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,15 @@ import (
configv1client "github.com/openshift/client-go/config/clientset/versioned/typed/config/v1"
"k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
"k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/client-go/discovery"
"k8s.io/client-go/dynamic"
"k8s.io/klog/v2"

"github.com/openshift/insights-operator/pkg/record"
"github.com/openshift/insights-operator/pkg/utils"
"github.com/openshift/insights-operator/pkg/utils/anonymize"
)

const (
Expand Down Expand Up @@ -167,6 +169,7 @@ func collectClusterOperatorResources(ctx context.Context,
if !ok {
klog.Warningf("Can't find spec for cluster operator resource %s", name)
}
anonymizeIdentityProviders(clusterResource.Object)
res = append(res, clusterOperatorResource{Spec: spec, Kind: kind, Name: name, APIVersion: apiVersion})
}
}
Expand Down Expand Up @@ -199,3 +202,30 @@ func getOperatorResourcesVersions(discoveryClient discovery.DiscoveryInterface)
}
return resourceVersionMap, nil
}

// anonymizeIdentityProviders tries to get an array of identity providers defined in OAuth config
// and anonymize potentially sensitive data - e.g LDAP domain, url
func anonymizeIdentityProviders(obj map[string]interface{}) {
ips, err := utils.NestedSliceWrapper(obj, "spec", "observedConfig", "oauthServer", "oauthConfig", "identityProviders")

// most of the clusteroperator resources will not have any identity provider config so silence the error
if err != nil {
return
}
sensittiveProviderAttributes := []string{"url", "bindDN", "hostname", "clientID", "hostedDomain", "issuer", "domainName"}
for _, ip := range ips {
ip, ok := ip.(map[string]interface{})
if !ok {
klog.Warningln("Failed to convert %v to map[string]interface{}", ip)
continue
}
for _, sensitiveVal := range sensittiveProviderAttributes {
// check if the sensitive value is in the provider definition under "provider" attribute
// and overwrite only if exists
if val, err := utils.NestedStringWrapper(ip, "provider", sensitiveVal); err == nil {
_ = unstructured.SetNestedField(ip, anonymize.String(val), "provider", sensitiveVal)
}
}
}
_ = unstructured.SetNestedSlice(obj, ips, "spec", "observedConfig", "oauthServer", "oauthConfig", "identityProviders")
}