Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.9] Bug 2017773: Anonymize identity provider attributes in … #527

Merged
merged 1 commit into from
Nov 9, 2021
Merged

[release-4.9] Bug 2017773: Anonymize identity provider attributes in … #527

merged 1 commit into from
Nov 9, 2021

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Oct 27, 2021

…the (#520)

Backport of #520

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

No new data

Documentation

No new doc

Unit Tests

No new test

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/???
https://bugzilla.redhat.com/show_bug.cgi?id=2017773
https://access.redhat.com/solutions/???

@tremes
[release-4.9] Bug 2017773: Anonymize identity provider attributes in …
e4c429b 
…the (openshift#520)

* Anonymize identity provider attributes in the
authentication.operator.openshift.io definition

* More robust way....
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 27, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2021

@tremes: This pull request references Bugzilla bug 2017773, which is invalid:

  • expected dependent Bugzilla bug 2017752 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.9] Bug 2017773: Anonymize identity provider attributes in …

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2021
@tremes
Copy link
Contributor Author

tremes commented Nov 1, 2021

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 1, 2021
@tremes
Copy link
Contributor Author

tremes commented Nov 1, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 1, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 1, 2021

@tremes: This pull request references Bugzilla bug 2017773, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2017752 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2017752 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (dmisharo@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rluders
rluders approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rluders, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

11 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@quarckster
Copy link
Contributor

/lgtm

@quarckster
Copy link
Contributor

/cherry-pick-approved

@quarckster quarckster removed their assignment Nov 8, 2021
@tremes
Copy link
Contributor Author

tremes commented Nov 9, 2021

/cherry-pick release-4.8

@openshift-cherrypick-robot
Copy link

@tremes: once the present PR merges, I will cherry-pick it on top of release-4.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hardys
Copy link

hardys commented Nov 9, 2021

/cherry-pick-approved

[patch-manager] @quarckster you're configured in the prow config to approve but you need to issue the command /label cherry-pick-approved

@quarckster
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 9, 2021
@rluders
Copy link
Contributor

rluders commented Nov 9, 2021

/override ci/prow/lint

@openshift-ci
Copy link

openshift-ci bot commented Nov 9, 2021

@rluders: Overrode contexts on behalf of rluders: ci/prow/lint

In response to this:

/override ci/prow/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit dd4d72c into openshift:release-4.9 Nov 9, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 9, 2021

@tremes: All pull requests linked via external trackers have merged:

Bugzilla bug 2017773 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2017773: Anonymize identity provider attributes in …

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 9, 2021
Closed
@openshift-cherrypick-robot
Copy link

@tremes: new pull request created: #539

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tremes added a commit to tremes/insights-operator that referenced this pull request Nov 10, 2021
@tremes
[release-4.8] Bug 2021572: Anonymize identity provider attributes in …
b808844 
…the (openshift#520) (openshift#527)

* Anonymize identity provider attributes in the
authentication.operator.openshift.io definition

* More robust way....
@tremes tremes mentioned this pull request Nov 10, 2021
Merged
4 tasks
openshift-merge-robot pushed a commit that referenced this pull request Nov 18, 2021
@tremes
[release-4.8] Bug 2021572: Anonymize identity provider attributes in …
44ea072 
…the (#520) (#527) (#541)

* Anonymize identity provider attributes in the
authentication.operator.openshift.io definition

* More robust way....
tremes added a commit to tremes/insights-operator that referenced this pull request Nov 18, 2021
@tremes
[release-4.7] Bug 2024614: Anonymize identity provider attributes in …
0ba1ff5 
…the (openshift#520) (openshift#527) (openshift#541)

* Anonymize identity provider attributes in the
authentication.operator.openshift.io definition

* More robust way....
@tremes tremes mentioned this pull request Nov 18, 2021
Merged
4 tasks
openshift-merge-robot pushed a commit that referenced this pull request Nov 22, 2021
@tremes
[release-4.7] Bug 2024614: Anonymize identity provider attributes in …
6258ceb 
…the (#520) (#527) (#541) (#549)

* Anonymize identity provider attributes in the
authentication.operator.openshift.io definition

* More robust way....
@tremes tremes deleted the idp_anonymization_4.9 branch May 6, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rluders rluders rluders approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@Serhii1011010 Serhii1011010 Awaiting requested review from Serhii1011010

Assignees

@rluders rluders

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tremes @openshift-bot @quarckster @openshift-cherrypick-robot @hardys @rluders @openshift-merge-robot