Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2005816: make projectid and region anonymization consistent #534

Merged
merged 6 commits into from
Dec 15, 2021
Merged

Bug 2005816: make projectid and region anonymization consistent #534

merged 6 commits into from
Dec 15, 2021

Conversation

Serhii1011010
Copy link
Contributor

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • path/to/sample_data.json

Documentation

  • path/to/documentation.md

Unit Tests

  • path/to/file_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

Yes/No

References

https://issues.redhat.com/browse/CCXDEV-5970
https://bugzilla.redhat.com/show_bug.cgi?id=???
https://access.redhat.com/solutions/???

@openshift-ci
Copy link

openshift-ci bot commented Nov 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sergey1011010

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from natiiix and tremes November 4, 2021 15:40
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2021
tremes
tremes reviewed Nov 5, 2021
View reviewed changes
pkg/gatherers/clusterconfig/image_registries.go
if config.Status.Storage.Azure != nil {
anonymizeAzureStorage(config.Status.Storage.Azure)
}
if config.Status.Storage.GCS != nil {
anonymizeGCSStorage(config.Status.Storage.GCS)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here are not required right :)

@tremes
Copy link
Contributor

tremes commented Nov 5, 2021

@Sergey1011010 This won't be so easy. The projectID and region is on more places. E.g ./config/configmaps/kube-system/cluster-config-v1.json and then nodes, machinesets,..... as mentioned in the BZ.

@Serhii1011010 Serhii1011010 force-pushed the make-projectid-and-region-anonymization-consistent branch from 11ca907 to 58cc34c Compare November 12, 2021 13:29
natiiix
natiiix reviewed Nov 15, 2021
View reviewed changes
Copy link
Contributor

@natiiix natiiix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems quite alright to me just by looking at the code, but shouldn't there be at least some tests, or is this one of those cases where it's very difficult to create a unit test due to the fake API limitations?

@Serhii1011010
Copy link
Contributor Author

@natiiix well, it just extends the existing anonymization which wasn't tested before as well.

tremes
tremes reviewed Nov 30, 2021
View reviewed changes
pkg/utils/anonymize/unstructured.go

valueStr, _ := value.(string)
return unstructured.SetNestedField(data, String(valueStr), fields...)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was doing something very similar in pkg/utils/unstructerd_wrappers.go (but without anonymization/setting the field) so maybe we could move it there. WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's relates more to anonymize package than to utils.

@tremes
Copy link
Contributor

tremes commented Nov 30, 2021

@Sergey1011010 Correct, but it would be nice to add at least something - e.g the infrastucture gatherer (there's no dynamic client used) and cluster_config_v1_config_map.go is yours right :-P :) (maybe we could merge it with the configs_map.go gatherer, which also has some more "advanced" tests)

@tremes
Copy link
Contributor

tremes commented Nov 30, 2021

There's also existing BZ for this so you can update the PR please.

@Serhii1011010 Serhii1011010 changed the title make projectid and region anonymization consistent Bug 2005816: make projectid and region anonymization consistent Dec 7, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Dec 7, 2021
@openshift-ci
Copy link

openshift-ci bot commented Dec 7, 2021

@Sergey1011010: This pull request references Bugzilla bug 2005816, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2005816: make projectid and region anonymization consistent

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 7, 2021
@Serhii1011010
Copy link
Contributor Author

@tremes do you mean this one?

@tremes
Copy link
Contributor

tremes commented Dec 7, 2021

@Sergey1011010 yes sir. Thanks

@tremes
Copy link
Contributor

tremes commented Dec 8, 2021

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Dec 8, 2021

@tremes: This pull request references Bugzilla bug 2005816, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes
Copy link
Contributor

tremes commented Dec 8, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 8, 2021
@openshift-ci
Copy link

openshift-ci bot commented Dec 8, 2021

@tremes: This pull request references Bugzilla bug 2005816, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @JoaoFula

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes
Copy link
Contributor

tremes commented Dec 14, 2021

Reviewed & verified. Thank you!
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

22 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@Serhii1011010
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Dec 15, 2021

@Sergey1011010: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 0fefe84 into openshift:master Dec 15, 2021
@openshift-ci
Copy link

openshift-ci bot commented Dec 15, 2021

@Sergey1011010: All pull requests linked via external trackers have merged:

Bugzilla bug 2005816 has been moved to the MODIFIED state.

In response to this:

Bug 2005816: make projectid and region anonymization consistent

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natiiix natiiix natiiix left review comments

@tremes tremes tremes left review comments

@JoaoFula JoaoFula Awaiting requested review from JoaoFula

Assignees

@tremes tremes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Serhii1011010 @tremes @JoaoFula @openshift-bot @natiiix @openshift-merge-robot