Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Set default messages & reconcile clusteroperator status conditions (#584) #586

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented Mar 3, 2022

This reverts commit 11e44f0. After this
merged, some clusters are failing to install with this message:

unable to set initial cluster status:
ClusterOperator.config.openshift.io "insights" is invalid:
status.conditions.lastTransitionTime: Required value

OpenShift policy is to revert payload breaking changes immediately, and
the team can build their fix on top of the unrevert.

…tions (openshift#584)"

This reverts commit 11e44f0. After this
merged, some clusters are failing to install with this message:

```
unable to set initial cluster status:
ClusterOperator.config.openshift.io "insights" is invalid:
status.conditions.lastTransitionTime: Required value
```

OpenShift policy is to revert payload breaking changes immediately, and
the team can build their fix on top of the unrevert.
@tremes
Copy link
Contributor

tremes commented Mar 3, 2022

@stbenjam Thanks. Yes I just noticed some problems as well. Thank you.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2022
@tremes
Copy link
Contributor

tremes commented Mar 3, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2022
@stbenjam
Copy link
Member Author

stbenjam commented Mar 3, 2022

@tremes Thank you for understanding. To reintroduce this, you probably want to get a good run against e2e-metal-ipi-ovn-ipv6: openshift/release#26721 adds it to this repo

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@deads2k
Copy link
Contributor

deads2k commented Mar 3, 2022

opened after the latest merge to master. upgrade failure was unrelated. merging to fix master.

@deads2k deads2k merged commit 2acfbc1 into openshift:master Mar 3, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 3, 2022

@stbenjam: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants