Bug 1782151 - override node selector #59
Conversation
To ensure the deployment works properly in case of default node selector is set.
openshift-ci-robot
added
size/XS
|
Followed pattern of other operators (such as https://github.com/openshift/cluster-monitoring-operator/blob/670ebc4f5998613d21b49420f52415eddb26c4c7/manifests/0000_50_cluster_monitoring_operator_01-namespace.yaml) |
|
@quarckster could you help with verification based on the BZ description? |
|
/retest |
|
@iNecas I verified it on 4.3.0-0.nightly-2019-12-12-021332. I followed steps described in this comment https://bugzilla.redhat.com/show_bug.cgi?id=1782151#c0. I patched openshift-insights namespace metadata with |
|
/lgtm based on @quarckster comment |
|
/lgtm |
|
@iNecas: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Ok, I give up, @mfojtik / @derekwaynecarr / @smarterclayton: anyone wants to approve this one? Should be XS |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iNecas, mfojtik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
To ensure the deployment works properly in case of default node selector
is set.