Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update of the arch.md document #626

Merged
merged 5 commits into from
Jun 2, 2022

Conversation

tremes
Copy link
Contributor

@tremes tremes commented May 18, 2022

This updates the docs/arch.md document. It's still not a masterpiece, but it's improving. This PR:

  • describes all the config options in the support secret
  • updates the clusteroperator conditions & status section
  • updates, simplifies and reword some important sections

The PR #621 should be merged first!!!

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

No new data

Documentation

Major update of the docs/arch.md document

Unit Tests

No new test

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/???
https://bugzilla.redhat.com/show_bug.cgi?id=???
https://access.redhat.com/solutions/???

@openshift-ci openshift-ci bot requested review from iNecas and natiiix May 18, 2022 11:59
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2022
docs/arch.md Outdated Show resolved Hide resolved
docs/arch.md Outdated Show resolved Hide resolved
docs/arch.md Outdated Show resolved Hide resolved
docs/arch.md Outdated Show resolved Hide resolved
tremes and others added 4 commits May 19, 2022 07:40
Co-authored-by: Joao Fula <hsifula@gmail.com>
Co-authored-by: Joao Fula <hsifula@gmail.com>
Co-authored-by: Joao Fula <hsifula@gmail.com>
Co-authored-by: Joao Fula <hsifula@gmail.com>
@xJustin
Copy link
Contributor

xJustin commented May 19, 2022

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label May 19, 2022
@JoaoFula
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 19, 2022
Copy link
Contributor

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reviewed all changes. Looks good.

@openshift-ci
Copy link

openshift-ci bot commented May 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rluders, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rluders
Copy link
Contributor

rluders commented May 23, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@tremes
Copy link
Contributor Author

tremes commented May 23, 2022

/override ci/prow/insights-operator-e2e-tests

@openshift-ci
Copy link

openshift-ci bot commented May 23, 2022

@tremes: Overrode contexts on behalf of tremes: ci/prow/insights-operator-e2e-tests

In response to this:

/override ci/prow/insights-operator-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sferich888
Copy link

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label May 31, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 3eada68 and 8 for PR HEAD ae4f7d3 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 3eada68 and 7 for PR HEAD ae4f7d3 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3eada68 and 6 for PR HEAD ae4f7d3 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD b916a9c and 5 for PR HEAD ae4f7d3 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD b916a9c and 4 for PR HEAD ae4f7d3 in total

@openshift-ci
Copy link

openshift-ci bot commented Jun 2, 2022

@tremes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 4886cf7 into openshift:master Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants