Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Implement Prometheus Collector pattern (#607)" #635

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Revert "Implement Prometheus Collector pattern (#607)" #635

merged 1 commit into from
Jun 3, 2022

Conversation

neisw
Copy link
Contributor

@neisw neisw commented Jun 3, 2022

This reverts commit b916a9c.

We believe #607 broke nightly builds due to a missing entry in image-references similar to https://github.com/openshift/cluster-network-operator/blob/master/manifests/image-references#L17-L20

The fix with the reverted code and updated image-references can be tested by adding

/test e2e-metal-ipi-ovn-ipv6

See https://issues.redhat.com/browse/TRT-282 for more details

@openshift-ci openshift-ci bot requested review from natiiix and tisnik June 3, 2022 12:18
@tremes
Copy link
Contributor

tremes commented Jun 3, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neisw, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2022
@tremes
Copy link
Contributor

tremes commented Jun 3, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2022
@tremes
Copy link
Contributor

tremes commented Jun 3, 2022

Revert. I am adding the no FF labels.
/label qe-approved
/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Jun 3, 2022
@dcbw dcbw mentioned this pull request Jun 3, 2022
Merged
@Prashanth684
Copy link

this PR is needed to unblock non x86 architecture releases too

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 4886cf7 and 8 for PR HEAD 4911b58 in total

@openshift-ci
Copy link

openshift-ci bot commented Jun 3, 2022

@neisw: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 5c7f142 into openshift:master Jun 3, 2022
@natiiix natiiix mentioned this pull request Jun 6, 2022
Merged
4 tasks
natiiix added a commit to natiiix/insights-operator that referenced this pull request Jun 6, 2022
@natiiix
Revert "Revert "Implement Prometheus Collector pattern (openshift#607)…
911fff3 
…" (openshift#635)"

This reverts commit 5c7f142.
openshift-merge-robot pushed a commit that referenced this pull request Jun 6, 2022
@natiiix
Implement Prometheus Collector pattern (#637)
062a9c7 
* Fix: Add kube-rbac-proxy to image-references

* Revert "Revert "Implement Prometheus Collector pattern (#607)" (#635)"

This reverts commit 5c7f142.

* Update IBM cloud deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natiiix natiiix Awaiting requested review from natiiix

@tisnik tisnik Awaiting requested review from tisnik

Assignees

@tremes tremes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@neisw @tremes @Prashanth684 @openshift-ci-robot @openshift-merge-robot