Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating ose-insights-operator images to be consistent with ART #774

Merged
merged 1 commit into from
May 24, 2023
Merged

Updating ose-insights-operator images to be consistent with ART #774

merged 1 commit into from
May 24, 2023

Conversation

openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Apr 22, 2023 •
edited
Loading

Updating ose-insights-operator images to be consistent with ART
TLDR:
Component owners, please ensure that this PR merges as it impacts the fidelity
of your CI signal. Patch-manager / leads, this PR is a no-op from a product
perspective -- feel free to manually apply any labels (e.g. jira/valid-bug) to help the
PR merge as long as tests are passing. If the PR is labeled "needs-ok-to-test", this is
to limit costs for re-testing these PRs while they wait for review. Issue /ok-to-test
to remove this tag and help the PR to merge.

Detail:
This repository is out of sync with the downstream product builds for this component.
One or more images differ from those being used by ART to create product builds. This
should be addressed to ensure that the component's CI testing is accurately
reflecting what customers will experience.

The information within the following ART component metadata is driving this alignment
request: ose-insights-operator.yml.

The vast majority of these PRs are opened because a different Golang version is being
used to build the downstream component. ART compiles most components with the version
of Golang being used by the control plane for a given OpenShift release. Exceptions
to this convention (i.e. you believe your component must be compiled with a Golang
version independent from the control plane) must be granted by the OpenShift
architecture team and communicated to the ART team.

Roles & Responsibilities:

  • Component owners are responsible for ensuring these alignment PRs merge with passing
    tests OR that necessary metadata changes are reported to the ART team: @release-artists
    in #aos-art on Slack. If necessary, the changes required by this pull request can be
    introduced with a separate PR opened by the component team. Once the repository is aligned,
    this PR will be closed automatically.
  • Patch-manager or those with sufficient privileges within this repository may add
    any required labels to ensure the PR merges once tests are passing. Downstream builds
    are already being built with these changes. Merging this PR only improves the fidelity
    of our CI.

ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image).
In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:

build_root:
  from_repository: true

If you have any questions about this pull request, please reach out to @release-artists in the #aos-art coreos slack channel.

@openshift-bot openshift-bot force-pushed the art-consistency-openshift-4.14-ose-insights-operator branch from 8596ea9 to 9b97ac4 Compare April 22, 2023 09:20
@openshift-bot openshift-bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Apr 22, 2023
@openshift-ci openshift-ci bot requested review from rhrmo and tremes April 22, 2023 09:21
@tremes
Copy link
Contributor

tremes commented Apr 24, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-bot, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 40feabb and 2 for PR HEAD 9b97ac4 in total

@tremes
Copy link
Contributor

tremes commented Apr 26, 2023

/test insights-operator-e2e-tests

@tremes
Copy link
Contributor

tremes commented Apr 28, 2023

/retest

3 similar comments
@tremes
Copy link
Contributor

tremes commented May 4, 2023

/retest

@tremes
Copy link
Contributor

tremes commented May 5, 2023

/retest

@tremes
Copy link
Contributor

tremes commented May 15, 2023

/retest

@tremes
Copy link
Contributor

tremes commented May 16, 2023

/test insights-operator-e2e-tests

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 08b4171 and 1 for PR HEAD 9b97ac4 in total

@tremes
Copy link
Contributor

tremes commented May 17, 2023

/test insights-operator-e2e-tests

@tremes
Copy link
Contributor

tremes commented May 22, 2023

/retest

@deads2k deads2k added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 24, 2023
@deads2k
Copy link
Contributor

deads2k commented May 24, 2023

need to get build levels correct. labelling

@openshift-ci
Copy link

openshift-ci bot commented May 24, 2023

@openshift-bot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 19b5a9c into openshift:master May 24, 2023
JoaoFula pushed a commit to JoaoFula/insights-operator that referenced this pull request Jan 23, 2024
@openshift-bot @JoaoFula
Updating ose-insights-operator images to be consistent with ART (open…
a9f3a71 
…shift#774)

Reconciling with https://github.com/openshift/ocp-build-data/tree/7575d251c23bb6784e1f762f3566c2770b051097/images/ose-insights-operator.yml

Co-authored-by: AOS Automation Release Team <noreply@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhrmo rhrmo Awaiting requested review from rhrmo

@tremes tremes Awaiting requested review from tremes

Assignees

@tremes tremes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@openshift-bot @tremes @openshift-ci-robot @deads2k @openshift-merge-robot