Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-13786: gather PDBs only from openshift namespaces #780

Merged
merged 4 commits into from
May 26, 2023
Merged

OCPBUGS-13786: gather PDBs only from openshift namespaces #780

merged 4 commits into from
May 26, 2023

Conversation

rhrmo
Copy link
Contributor

@rhrmo rhrmo commented May 21, 2023 •
edited
Loading

This PR fixes the gathering of PDBs so they are gathered only from openshift namespaces and limits the number of gathered PDBs to 100.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

no update

Documentation

  • docs/gathered-data.md#PodDisruptionBudgets

Unit Tests

  • /pkg/gatherers/clusterconfig/pod_disruption_budgets_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-10830

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 21, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented May 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhrmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2023
@rhrmo rhrmo changed the title gather PDBs only from openshift namespaces OCPBUGS-13786: gather PDBs only from openshift namespaces May 23, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 23, 2023
@openshift-ci-robot
Copy link
Contributor

@rhrmo: This pull request references Jira Issue OCPBUGS-13786, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @JoaoFula

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR implements a new data enhancement to...

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • path/to/sample_data.json

Documentation

  • path/to/documentation.md

Unit Tests

  • path/to/file_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

Yes/No

References

https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from JoaoFula May 23, 2023 07:04
@openshift-ci-robot
Copy link
Contributor

@rhrmo: This pull request references Jira Issue OCPBUGS-13786, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @JoaoFula

In response to this:

This PR fixes the gathering of PDBs so they are gathered only from openshift namespaces and limits the number of gathered PDBs to 100.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

no update

Documentation

  • docs/gathered-data.md#PodDisruptionBudgets

Unit Tests

  • /pkg/gatherers/clusterconfig/pod_disruption_budgets_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-10830

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhrmo rhrmo marked this pull request as ready for review May 23, 2023 07:17
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 23, 2023
@openshift-ci openshift-ci bot requested review from rluders and tremes May 23, 2023 07:20
@tremes
Copy link
Contributor

tremes commented May 25, 2023

I reviewed and briefly tested. Thanks.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 19b5a9c and 2 for PR HEAD ea514b7 in total

@tremes
Copy link
Contributor

tremes commented May 26, 2023

/override ci/prow/e2e-metal-ipi-ovn-ipv6

@tremes
Copy link
Contributor

tremes commented May 26, 2023

/test ci/prow/e2e-agnostic-upgrade

@openshift-ci
Copy link

openshift-ci bot commented May 26, 2023

@tremes: Overrode contexts on behalf of tremes: ci/prow/e2e-metal-ipi-ovn-ipv6

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented May 26, 2023

@tremes: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e
  • /test e2e-agnostic-upgrade
  • /test e2e-metal-ipi-ovn-ipv6
  • /test images
  • /test insights-operator-e2e-tests
  • /test lint
  • /test unit

Use /test all to run all jobs.

In response to this:

/test ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes
Copy link
Contributor

tremes commented May 26, 2023

/test e2e-agnostic-upgrade

@openshift-ci
Copy link

openshift-ci bot commented May 26, 2023

@rhrmo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 0ef6d76 into openshift:master May 26, 2023
@openshift-ci-robot
Copy link
Contributor

@rhrmo: Jira Issue OCPBUGS-13786: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13786 has been moved to the MODIFIED state.

In response to this:

This PR fixes the gathering of PDBs so they are gathered only from openshift namespaces and limits the number of gathered PDBs to 100.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

no update

Documentation

  • docs/gathered-data.md#PodDisruptionBudgets

Unit Tests

  • /pkg/gatherers/clusterconfig/pod_disruption_budgets_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-10830

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhrmo
Copy link
Contributor Author

rhrmo commented May 31, 2023

/cherry-pick release-4.13

@openshift-cherrypick-robot
Copy link

@rhrmo: new pull request created: #786

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 31, 2023
Merged
JoaoFula pushed a commit to JoaoFula/insights-operator that referenced this pull request Jan 23, 2024
@rhrmo @JoaoFula
OCPBUGS-13786: gather PDBs only from openshift namespaces (openshift#780
fa57d4a 
)

* Gather PDB only from openshift namespace

* minor docs update

* minor unit test refactor

* fix based on review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremes tremes tremes left review comments

@JoaoFula JoaoFula Awaiting requested review from JoaoFula

@rluders rluders Awaiting requested review from rluders

Assignees

@tremes tremes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rhrmo @openshift-ci-robot @tremes @openshift-cherrypick-robot @openshift-merge-robot