Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-14475: extend configmap gatherer to get gateway-mode-config #788

Merged
merged 1 commit into from
Jun 8, 2023
Merged

OCPBUGS-14475: extend configmap gatherer to get gateway-mode-config #788

merged 1 commit into from
Jun 8, 2023

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Jun 2, 2023

Extends the existing configmap gatherer to gather gateway-mode-config configmap from openshift-network-operator namespace

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/configmaps/openshift-network-operator/gateway-mode-config/mode.json

Documentation

  • docs/gathered-data.md

Unit Tests

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/INSIGHTOCP-1197
https://issues.redhat.com/browse/OCPBUGS-14475
https://issues.redhat.com/browse/CCXDEV-10980

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 2, 2023
@openshift-ci-robot
Copy link
Contributor

@tremes: This pull request references Jira Issue OCPBUGS-14475, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @JoaoFula

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Extends the existing configmap gatherer to gather gateway-mode-config configmap from openshift-network-operator namespace

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/configmaps/openshift-network-operator/gateway-mode-config/mode.json

Documentation

  • docs/gathered-data.md

Unit Tests

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/INSIGHTOCP-1197
https://issues.redhat.com/browse/OCPBUGS-14475
https://issues.redhat.com/browse/CCXDEV-10980

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from JoaoFula, rhrmo and rluders June 2, 2023 10:01
@openshift-ci
Copy link

openshift-ci bot commented Jun 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2023
@rhrmo
Copy link
Contributor

rhrmo commented Jun 7, 2023

I reviewed the code and tested it.

/lgtm
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 49a6adf and 2 for PR HEAD 5a1a297 in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 49a6adf and 2 for PR HEAD 5a1a297 in total

@tremes
Copy link
Contributor Author

tremes commented Jun 7, 2023

Let's fix the lint somewhere else..e.g in #787.
/override ci/prow/lint

@openshift-ci
Copy link

openshift-ci bot commented Jun 7, 2023

@tremes: Overrode contexts on behalf of tremes: ci/prow/lint

In response to this:

Let's fix the lint somewhere else..e.g in #787.
/override ci/prow/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes
Copy link
Contributor Author

tremes commented Jun 8, 2023

/override ci/prow/lint

@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2023

@tremes: Overrode contexts on behalf of tremes: ci/prow/lint

In response to this:

/override ci/prow/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes
Copy link
Contributor Author

tremes commented Jun 8, 2023

/test e2e

@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2023

@tremes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 2715343 into openshift:master Jun 8, 2023
@openshift-ci-robot
Copy link
Contributor

@tremes: Jira Issue OCPBUGS-14475: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-14475 has been moved to the MODIFIED state.

In response to this:

Extends the existing configmap gatherer to gather gateway-mode-config configmap from openshift-network-operator namespace

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/configmaps/openshift-network-operator/gateway-mode-config/mode.json

Documentation

  • docs/gathered-data.md

Unit Tests

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/INSIGHTOCP-1197
https://issues.redhat.com/browse/OCPBUGS-14475
https://issues.redhat.com/browse/CCXDEV-10980

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tremes added a commit to tremes/insights-operator that referenced this pull request Jun 8, 2023
@tremes
[release-4.13] OCPBUGS-14773: extend configmap gatherer to get gatewa…
c40c4c5 
…y-mode-config (openshift#788)
@tremes tremes mentioned this pull request Jun 8, 2023
Merged
5 tasks
openshift-merge-robot pushed a commit that referenced this pull request Jun 26, 2023
@tremes
[release-4.13] OCPBUGS-14773: extend configmap gatherer to get gatewa…
f87e412 
…y-mode-config (#788) (#791)
tremes added a commit to tremes/insights-operator that referenced this pull request Jun 26, 2023
@tremes
[release-4.12] OCPBUGS-15414: extend configmap gatherer to get gatewa…
43da6bc 
…y-mode-config (openshift#788) (openshift#791)
tremes added a commit to tremes/insights-operator that referenced this pull request Jun 27, 2023
@tremes
[release-4.11] OCPBUGS-15446: extend configmap gatherer to get gatewa…
2c77b22 
…y-mode-config (openshift#788) (openshift#791)
@tremes tremes mentioned this pull request Jun 27, 2023
Merged
5 tasks
openshift-merge-robot pushed a commit that referenced this pull request Jun 27, 2023
@tremes
[release-4.12] OCPBUGS-15414: extend configmap gatherer to get gatewa…
6f127a4 
…y-mode-config (#788) (#791) (#801)
openshift-merge-robot pushed a commit that referenced this pull request Jun 30, 2023
@tremes
[release-4.11] OCPBUGS-15446: extend configmap gatherer to get gatewa…
1fe479a 
…y-mode-config (#788) (#791) (#802)
@tremes tremes deleted the network-cm branch July 27, 2023 07:16
JoaoFula pushed a commit to JoaoFula/insights-operator that referenced this pull request Jan 23, 2024
@tremes @JoaoFula
OCPBUGS-14475: extend configmap gatherer to get gateway-mode-config (o…
ee2b05b 
…penshift#788)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoaoFula JoaoFula Awaiting requested review from JoaoFula

@rhrmo rhrmo Awaiting requested review from rhrmo

@rluders rluders Awaiting requested review from rluders

Assignees

@rhrmo rhrmo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tremes @openshift-ci-robot @rhrmo @openshift-merge-robot