-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-14771: run an extra config informer in the tech preview #792
OCPBUGS-14771: run an extra config informer in the tech preview #792
Conversation
86109d3
to
4355e17
Compare
@tremes: This pull request references Jira Issue OCPBUGS-14771, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@tremes: This pull request references Jira Issue OCPBUGS-14771, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tremes: This pull request references Jira Issue OCPBUGS-14771, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We need to exclude the |
@tremes: Overrode contexts on behalf of tremes: ci/prow/lint In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncaak, tremes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tremes: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@tremes: Jira Issue OCPBUGS-14771: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-14771 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…shift#792) * OCPBUGS-14771 run an extra config informer in the tech preview * add resync time
#779 changed the logic in
operator.go
so that theconfiginformer
runs every time (and not only in the techpreview). This caused the problem (unable to sync cache -> restart every 10 min) in the techpreview, because it doesn't seem to be possible to add an additional informer, when it's already started.This creates (and starts) a new extra config informer only in the techpreview when the feature is enabled.
Categories
Sample Archive
-no new data
Documentation
Unit Tests
Privacy
Yes. There are no sensitive data in the newly collected information.
Changelog
Breaking Changes
No
References
https://issues.redhat.com/browse/OCPBUGS-14771