Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ConfigMaps gatherer docs #817

Merged

Conversation

jholecek-rh
Copy link
Contributor

This PR improves documentation of the GatherConfigMaps gatherer.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

N/A?

Documentation

  • docs/gathered-data.md

Unit Tests

None.

Privacy

N/A

Changelog

No, N/A.

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-11558

@openshift-ci openshift-ci bot requested review from rhrmo and tremes August 14, 2023 08:26
@tremes
Copy link
Contributor

tremes commented Aug 14, 2023

Just docs update
/override ci/prow/insights-operator-e2e-tests
/override ci/prow/e2e-gcp-ovn-techpreview

@openshift-ci
Copy link

openshift-ci bot commented Aug 14, 2023

@tremes: Overrode contexts on behalf of tremes: ci/prow/e2e-gcp-ovn-techpreview, ci/prow/insights-operator-e2e-tests

In response to this:

Just docs update
/override ci/prow/insights-operator-e2e-tests
/override ci/prow/e2e-gcp-ovn-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes
Copy link
Contributor

tremes commented Aug 15, 2023

/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/insights-operator-e2e-tests
/override ci/prow/e2e-agnostic-upgrade
/override ci/prow/e2e
/override ci/prow/e2e-gcp-ovn-techpreview

@jholecek-rh
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented Aug 15, 2023

@tremes: Overrode contexts on behalf of tremes: ci/prow/e2e, ci/prow/e2e-agnostic-upgrade, ci/prow/e2e-gcp-ovn-techpreview, ci/prow/e2e-metal-ipi-ovn-ipv6, ci/prow/insights-operator-e2e-tests

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/insights-operator-e2e-tests
/override ci/prow/e2e-agnostic-upgrade
/override ci/prow/e2e
/override ci/prow/e2e-gcp-ovn-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes
Copy link
Contributor

tremes commented Aug 15, 2023

Thanks @jholecek-rh.
/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jholecek-rh, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2023
@tremes
Copy link
Contributor

tremes commented Aug 15, 2023

Simple, good docs change. I am adding the qe label myself.
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 15, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD f936f69 and 2 for PR HEAD f4760d4 in total

@tremes
Copy link
Contributor

tremes commented Aug 15, 2023

/override ci/prow/e2e-metal-ipi-ovn-ipv6

@openshift-ci
Copy link

openshift-ci bot commented Aug 15, 2023

@tremes: Overrode contexts on behalf of tremes: ci/prow/e2e-metal-ipi-ovn-ipv6

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 48c85cd into openshift:master Aug 15, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 15, 2023

@jholecek-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

JoaoFula pushed a commit to JoaoFula/insights-operator that referenced this pull request Jan 23, 2024
* Improve ConfigMaps gatherer docs

* Apply gofmt -s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants