Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-19476: update Insights report config logging #824

Merged
merged 1 commit into from
Sep 22, 2023
Merged

OCPBUGS-19476: update Insights report config logging #824

merged 1 commit into from
Sep 22, 2023

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Sep 21, 2023

Do not log the complete config

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

Documentation

Unit Tests

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/OCPBUGS-19476
https://access.redhat.com/solutions/???

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 21, 2023
@openshift-ci-robot
Copy link
Contributor

@tremes: This pull request references Jira Issue OCPBUGS-19476, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Do not log the complete config

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

Documentation

Unit Tests

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/OCPBUGS-19476
https://access.redhat.com/solutions/???

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes
Copy link
Contributor Author

tremes commented Sep 21, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@tremes: This pull request references Jira Issue OCPBUGS-19476, which is invalid:

  • expected the bug to target the "4.15.0" version, but it targets "4.15" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes
Copy link
Contributor Author

tremes commented Sep 21, 2023

Minor logging update.
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-agnostic-upgrade
/override ci/prow/e2e-gcp-ovn-techpreview

@tremes
Copy link
Contributor Author

tremes commented Sep 21, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@tremes: This pull request references Jira Issue OCPBUGS-19476, which is invalid:

  • expected the bug to target the "4.15.0" version, but it targets "4.15" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes
Copy link
Contributor Author

tremes commented Sep 21, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 21, 2023
@openshift-ci-robot
Copy link
Contributor

@tremes: This pull request references Jira Issue OCPBUGS-19476, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @JoaoFula

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 21, 2023

@tremes: Overrode contexts on behalf of tremes: ci/prow/e2e-agnostic-upgrade, ci/prow/e2e-gcp-ovn-techpreview, ci/prow/e2e-metal-ipi-ovn-ipv6

In response to this:

Minor logging update.
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-agnostic-upgrade
/override ci/prow/e2e-gcp-ovn-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ncaak
ncaak approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@ncaak ncaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tremes
Copy link
Contributor Author

tremes commented Sep 22, 2023

/test insights-operator-e2e-tests

1 similar comment
@tremes
Copy link
Contributor Author

tremes commented Sep 22, 2023

/test insights-operator-e2e-tests

@tremes
Copy link
Contributor Author

tremes commented Sep 22, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 22, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4e90dbb and 2 for PR HEAD d6b8d8f in total

@tremes
Copy link
Contributor Author

tremes commented Sep 22, 2023

/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-agnostic-upgrade
/override ci/prow/e2e

@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2023

@tremes: Overrode contexts on behalf of tremes: ci/prow/e2e, ci/prow/e2e-agnostic-upgrade, ci/prow/e2e-metal-ipi-ovn-ipv6

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-agnostic-upgrade
/override ci/prow/e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 8ca514d into openshift:master Sep 22, 2023
@openshift-ci-robot
Copy link
Contributor

@tremes: Jira Issue OCPBUGS-19476: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19476 has been moved to the MODIFIED state.

In response to this:

Do not log the complete config

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

Documentation

Unit Tests

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/OCPBUGS-19476
https://access.redhat.com/solutions/???

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes
Copy link
Contributor Author

tremes commented Sep 22, 2023

/cherry-pick release-4.14

@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2023

@tremes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-cherrypick-robot
Copy link

@tremes: new pull request created: #826

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 22, 2023
Merged
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-09-27-073353

JoaoFula pushed a commit to JoaoFula/insights-operator that referenced this pull request Jan 23, 2024
@tremes @JoaoFula
OCPBUGS-19476: update Insights report config logging (openshift#824)
c5bcc1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncaak ncaak ncaak approved these changes

@JoaoFula JoaoFula Awaiting requested review from JoaoFula

@rluders rluders Awaiting requested review from rluders

Assignees

@ncaak ncaak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tremes @openshift-ci-robot @openshift-cherrypick-robot @openshift-merge-robot @ncaak