First minimal PoC version for moving the configuration to configmap

[tremes]

This is minimal PoC for introducing the Insights Operator's configuration in the new insights-config configmap instead of the support secret configuration. The support secret configuration continues to work (to keep backward compatibility), but the configmap takes precedence if exists.

This PR introduces following new files:

• pkg/config/configobserver/configmapobserver.go - basic configmap observer watching the configmap's changes using Kubernetes informer
• pkg/config/configobserver/config_aggregator.go - this is a listener for both - the original "legacy" secret configobserver as well as the new configmap observer. The idea here is to aggregate or merge the config from both sources at one place.

The insights-config configmap is supposed to live in the openshift-insights namespace and right now it can look like:

apiVersion: v1
kind: ConfigMap
metadata:
  name: 'insights-config'
  namespace: openshift-insights
data:
 config.yaml: |
   dataReporting:
     interval: 1h
     uploadEndpoint: https://console.redhat.com/api/ingress/v1/upload
binaryData: {}
immutable: false

Right now the config map allows you to override the following config options:

• interval
• upload endpoint
• conditional gatherer endpoint
• storage path
• download endpoint for tech preview
• processing status endpoint (tech preview only)

The configmap (as well as the config) structure is defined in the pkg/config/types.go so please review this one very carefully and feel free to suggest changes (for example naming, structure, etc.)

Categories

• Bugfix
• Data Enhancement
• Feature
• Backporting
• Others (CI, Infrastructure, Documentation)

Sample Archive

• no new data

Documentation

Unit Tests

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

Yes/No

References

https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???

[tremes]

/test insights-operator-e2e-tests

[openshift-merge-robot]

@tremes: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/insights-operator-e2e-tests	4add5bb	link	true	/test insights-operator-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[rluders]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak, rluders, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ncaak,rluders,tremes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tremes]

/retest

[JoaoFula]

/label qe-approved

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD f6c7583 and 2 for PR HEAD 2f0cc66 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 67f607e and 1 for PR HEAD 2f0cc66 in total

[tremes]

/test insights-operator-e2e-tests

[tremes]

/test insights-operator-e2e-tests

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d25171c and 0 for PR HEAD 2f0cc66 in total

[tremes]

/override ci/prow/e2e-metal-ipi-ovn-ipv6

[openshift-ci]

@tremes: Overrode contexts on behalf of tremes: ci/prow/e2e-metal-ipi-ovn-ipv6

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

/hold

Revision 2f0cc66 was retested 3 times: holding

[tremes]

/unhold
/test insights-operator-e2e-tests

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d25171c and 2 for PR HEAD 2f0cc66 in total

[tremes]

/test e2e-gcp-ovn-techpreview

[tremes]

One test failure - I am working on the test fix.
/override ci/prow/e2e-gcp-ovn-techpreview

[openshift-ci]

@tremes: Overrode contexts on behalf of tremes: ci/prow/e2e-gcp-ovn-techpreview

In response to this:

One test failure - I am working on the test fix.
/override ci/prow/e2e-gcp-ovn-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tremes]

/override ci/prow/e2e-gcp-ovn-techpreview

[openshift-ci]

@tremes: Overrode contexts on behalf of tremes: ci/prow/e2e-gcp-ovn-techpreview

In response to this:

/override ci/prow/e2e-gcp-ovn-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@tremes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.