Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extends obfuscation options in the configmap #844

Merged
merged 1 commit into from
Oct 31, 2023
Merged

extends obfuscation options in the configmap #844

merged 1 commit into from
Oct 31, 2023

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Oct 19, 2023 •
edited
Loading

This PR adds a new obfuscation option to the new insights-config config map. This option allows you to enable the "legacy global obfuscation" as well as the new workloads_names obfuscation, which is currently only used for DVO metrics.

Example can look like:

kind: ConfigMap
apiVersion: v1
metadata:
  name: insights-config
  namespace: openshift-insights
immutable: false
data:
  config.yaml: |
    dataReporting:
       obfuscation:
       - workload_names
       - networking

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • no new data

Documentation

  • path/to/documentation.md

Unit Tests

  • path/to/file_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

Yes/No

References

https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2023
@openshift-ci openshift-ci bot requested review from ncaak and rhrmo October 19, 2023 09:41
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
@tremes tremes changed the title WIP extends obfuscation options in the configmap extends obfuscation options in the configmap Oct 19, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2023
@tremes
Copy link
Contributor Author

tremes commented Oct 20, 2023

/retest

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2023
rluders
rluders approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
ncaak
ncaak reviewed Oct 23, 2023
View reviewed changes
pkg/config/types.go Outdated Show resolved Hide resolved
ncaak
ncaak approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@ncaak ncaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
@ncaak
Copy link
Contributor

ncaak commented Oct 23, 2023

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Oct 23, 2023
@ncaak
Copy link
Contributor

ncaak commented Oct 24, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 26, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2023
ncaak
ncaak approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@ncaak ncaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak, rluders, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ncaak,rluders,tremes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tremes
Copy link
Contributor Author

tremes commented Oct 27, 2023

/test e2e-gcp-ovn-techpreview

2 similar comments
@tremes
Copy link
Contributor Author

tremes commented Oct 30, 2023

/test e2e-gcp-ovn-techpreview

@tremes
Copy link
Contributor Author

tremes commented Oct 30, 2023

/test e2e-gcp-ovn-techpreview

@openshift-ci
Copy link

openshift-ci bot commented Oct 30, 2023

@tremes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoaoFula
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 31, 2023
@openshift-ci openshift-ci bot merged commit 30ef95a into openshift:master Oct 31, 2023
9 checks passed
JoaoFula pushed a commit to JoaoFula/insights-operator that referenced this pull request Jan 23, 2024
@tremes @JoaoFula
extends obfuscation options in the configmap (openshift#844)
6e729cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncaak ncaak ncaak approved these changes

@rluders rluders rluders approved these changes

@rhrmo rhrmo Awaiting requested review from rhrmo

Assignees

@rluders rluders

@ncaak ncaak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tremes @ncaak @JoaoFula @rluders @openshift-merge-robot