Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add retry logic to the DVO metrics gatherer #847

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Oct 20, 2023

This adds retry logic (with context timeout of 2 seconds) to the DVO metrics gatherer

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

no new data

Documentation

Unit Tests

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???

@openshift-ci openshift-ci bot requested review from rhrmo and rluders October 20, 2023 08:31
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2023
Copy link
Contributor

@ncaak ncaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2023
@tremes
Copy link
Contributor Author

tremes commented Oct 23, 2023

/test e2e-gcp-ovn-techpreview

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2023
Copy link
Contributor

@ncaak ncaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JoaoFula
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 26, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d240e30 and 2 for PR HEAD de6dfab in total

@tremes
Copy link
Contributor Author

tremes commented Oct 26, 2023

/override ci/prow/lint

@openshift-ci
Copy link

openshift-ci bot commented Oct 26, 2023

@tremes: Overrode contexts on behalf of tremes: ci/prow/lint

In response to this:

/override ci/prow/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes
Copy link
Contributor Author

tremes commented Oct 26, 2023

This is quite simple update of an existing gatherer. The tests are currently flaky so overriding.
/override ci/prow/insights-operator-e2e-tests
/override ci/prow/e2e-gcp-ovn-techpreview

@openshift-ci
Copy link

openshift-ci bot commented Oct 26, 2023

@tremes: Overrode contexts on behalf of tremes: ci/prow/e2e-gcp-ovn-techpreview, ci/prow/insights-operator-e2e-tests

In response to this:

This is quite simple update of an existing gatherer. The tests are currently flaky so overriding.
/override ci/prow/insights-operator-e2e-tests
/override ci/prow/e2e-gcp-ovn-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit 8c0189a into openshift:master Oct 26, 2023
9 checks passed
@openshift-ci
Copy link

openshift-ci bot commented Oct 26, 2023

@tremes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

JoaoFula pushed a commit to JoaoFula/insights-operator that referenced this pull request Jan 23, 2024
* add retry logic to the DVO metrics gatherer

* increase the timeout and improve error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants