CCXDEV-11946: finalize the config update to the new config map #857

tremes · 2023-11-02T13:20:12Z

This finalizes the move of configuration from the legacy support secret to a new insights-config config map.
The configmap definition can look like:

data:
  config.yaml: |
    dataReporting:
      interval: 30m
      obfuscation:
      - workload_names
      - networking
    sca:
      disabled: false
    alerting:
      disabled: false
    proxy:
      httpProxy: http://example.com
      httpsProxy: https://example.com
      noProxy: test.org
    clusterTransfer:
      interval: 1h

The operator logs every config change and it looks like:

periodic.go:257] Configuration is 
	dataReporting:
		interval: 30m0s,
		uploadEndpoint: https://console.redhat.com/api/ingress/v1/upload,
		storagePath: /var/lib/insights-operator,
		downloadEndpoint: https://console.redhat.com/api/insights-results-aggregator/v2/cluster/%s/reports, 
		conditionalGathererEndpoint: https://console.redhat.com/api/gathering/gathering_rules,
		obfuscation: [workload_names networking]
	sca:
		disabled: false,
		endpoint: https://api.openshift.com/api/accounts_mgmt/v1/certificates,
		interval: 8h0m0s
	alerting:
		disabled: false
	clusterTransfer:
		endpoint: https://api.openshift.com/api/accounts_mgmt/v1/cluster_transfers/,
		interval: 1h0m0s
	proxy:
		httpProxy: http://example.com,
		httpsProxy: https://example.com,
		noProxy: test.org

Categories`

Sample Archive

no new data

Documentation

path/to/documentation.md

Unit Tests

path/to/file_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

Yes/No

References

https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???

tremes · 2023-11-03T12:44:51Z

I think this is not 100% at the moment.
/hold

tremes · 2023-11-07T07:14:39Z

/unhold

rluders

Tested and seems good.
/lgtm

openshift-ci · 2023-11-08T08:18:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rluders, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rluders,tremes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

JoaoFula · 2023-11-13T09:38:49Z

why is jira/valid-reference still being required?

openshift-ci-robot · 2023-11-27T12:57:21Z

@tremes: This pull request references CCXDEV-11946 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

This finalizes the move of configuration from the legacy support secret to a new insights-config config map.
The configmap definition can look like:
data:
 config.yaml: |
   dataReporting:
     interval: 30m
     obfuscation:
     - workload_names
     - networking
   sca:
     disabled: false
   alerting:
     disabled: false
   proxy:
     httpProxy: http://example.com
     httpsProxy: https://example.com
     noProxy: test.org
   clusterTransfer:
     interval: 1h
The operator logs every config change and it looks like:
periodic.go:257] Configuration is 
  dataReporting:
  	interval: 30m0s,
  	uploadEndpoint: https://console.redhat.com/api/ingress/v1/upload,
  	storagePath: /var/lib/insights-operator,
  	downloadEndpoint: https://console.redhat.com/api/insights-results-aggregator/v2/cluster/%s/reports, 
  	conditionalGathererEndpoint: https://console.redhat.com/api/gathering/gathering_rules,
  	obfuscation: [workload_names networking]
  sca:
  	disabled: false,
  	endpoint: https://api.openshift.com/api/accounts_mgmt/v1/certificates,
  	interval: 8h0m0s
  alerting:
  	disabled: false
  clusterTransfer:
  	endpoint: https://api.openshift.com/api/accounts_mgmt/v1/cluster_transfers/,
  	interval: 1h0m0s
  proxy:
  	httpProxy: http://example.com,
  	httpsProxy: https://example.com,
  	noProxy: test.org
Categories`

Bugfix

Data Enhancement

Feature

Backporting

Others (CI, Infrastructure, Documentation)

Sample Archive

no new data

Documentation

path/to/documentation.md

Unit Tests

path/to/file_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

Yes/No

References

https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JoaoFula · 2023-11-29T09:20:01Z

/label qe-approved

openshift-ci-robot · 2023-11-29T09:20:06Z

@tremes: This pull request references CCXDEV-11946 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

This finalizes the move of configuration from the legacy support secret to a new insights-config config map.
The configmap definition can look like:
data:
 config.yaml: |
   dataReporting:
     interval: 30m
     obfuscation:
     - workload_names
     - networking
   sca:
     disabled: false
   alerting:
     disabled: false
   proxy:
     httpProxy: http://example.com
     httpsProxy: https://example.com
     noProxy: test.org
   clusterTransfer:
     interval: 1h
The operator logs every config change and it looks like:
periodic.go:257] Configuration is 
  dataReporting:
  	interval: 30m0s,
  	uploadEndpoint: https://console.redhat.com/api/ingress/v1/upload,
  	storagePath: /var/lib/insights-operator,
  	downloadEndpoint: https://console.redhat.com/api/insights-results-aggregator/v2/cluster/%s/reports, 
  	conditionalGathererEndpoint: https://console.redhat.com/api/gathering/gathering_rules,
  	obfuscation: [workload_names networking]
  sca:
  	disabled: false,
  	endpoint: https://api.openshift.com/api/accounts_mgmt/v1/certificates,
  	interval: 8h0m0s
  alerting:
  	disabled: false
  clusterTransfer:
  	endpoint: https://api.openshift.com/api/accounts_mgmt/v1/cluster_transfers/,
  	interval: 1h0m0s
  proxy:
  	httpProxy: http://example.com,
  	httpsProxy: https://example.com,
  	noProxy: test.org
Categories`

Bugfix

Data Enhancement

Feature

Backporting

Others (CI, Infrastructure, Documentation)

Sample Archive

no new data

Documentation

path/to/documentation.md

Unit Tests

path/to/file_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

Yes/No

References

https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-11-29T10:46:41Z

/retest-required

Remaining retests: 0 against base HEAD f440fa0 and 2 for PR HEAD bf69261 in total

tremes · 2023-11-29T11:11:36Z

/test e2e-gcp-ovn-techpreview

tremes · 2023-11-29T15:31:35Z

/retest

tremes · 2023-11-30T08:17:12Z

/retest

tremes · 2023-11-30T11:53:12Z

/retest

tremes · 2023-12-01T08:12:04Z

/retest

openshift-ci-robot · 2023-12-01T10:34:06Z

/retest-required

Remaining retests: 0 against base HEAD 4d4542e and 1 for PR HEAD bf69261 in total

tremes · 2023-12-01T13:01:26Z

Our tests passing locally and we need to fix them. Overriding for this one.
/override ci/prow/e2e-gcp-ovn-techpreview
/override ci/prow/insights-operator-e2e-tests

openshift-ci · 2023-12-01T13:01:50Z

@tremes: Overrode contexts on behalf of tremes: ci/prow/e2e-gcp-ovn-techpreview, ci/prow/insights-operator-e2e-tests

In response to this:

Our tests passing locally and we need to fix them. Overriding for this one.
/override ci/prow/e2e-gcp-ovn-techpreview
/override ci/prow/insights-operator-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-12-01T15:17:22Z

@tremes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2023-12-01T20:56:18Z

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-insights-operator-container-v4.15.0-202312012031.p0.g9b91ed4.assembly.stream for distgit ose-insights-operator.
All builds following this will include this PR.

…hift#857) * insightsreport using new config_aggregator * prometheuscontroller using new config_aggregator * sca controller using new config_aggregator * status controller using new config_aggregator * clustertransfer controller using new config aggregator * clusterauthorizer using new config aggregator * files renaming * extend tests & final adjustments * update logging

tremes added 8 commits November 1, 2023 11:54

insightsreport using new config_aggregator

f7514e7

prometheuscontroller using new config_aggregator

83feb95

sca controller using new config_aggregator

a5d55aa

status controller using new config_aggregator

75c593b

clustertransfer controller using new config aggregator

a654065

clusterauthorizer using new config aggregator

90b4b3b

files renaming

b478123

extend tests & final adjustments

5080b4a

openshift-ci bot requested review from ncaak and rluders November 2, 2023 13:24

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2023

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2023

update logging

bf69261

tremes force-pushed the config-final branch from 5c9f504 to bf69261 Compare November 7, 2023 07:14

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2023

rluders approved these changes Nov 8, 2023

View reviewed changes

openshift-ci bot assigned rluders Nov 8, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2023

tremes changed the title ~~CCXDEV-11946 finalize the config update to the new config map~~ CCXDEV-11946: finalize the config update to the new config map Nov 27, 2023

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 27, 2023

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 29, 2023

openshift-merge-bot bot merged commit 9b91ed4 into openshift:master Dec 1, 2023
9 checks passed

CCXDEV-11946: finalize the config update to the new config map #857

CCXDEV-11946: finalize the config update to the new config map #857

Conversation

tremes commented Nov 2, 2023 • edited Loading

Categories`

Sample Archive

Documentation

Unit Tests

Privacy

Changelog

Breaking Changes

References

tremes commented Nov 3, 2023

tremes commented Nov 7, 2023

rluders left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Nov 8, 2023

JoaoFula commented Nov 13, 2023

openshift-ci-robot commented Nov 27, 2023 • edited by openshift-ci bot Loading

Categories`

Sample Archive

Documentation

Unit Tests

Privacy

Changelog

Breaking Changes

References

JoaoFula commented Nov 29, 2023

openshift-ci-robot commented Nov 29, 2023 • edited by openshift-ci bot Loading

Categories`

Sample Archive

Documentation

Unit Tests

Privacy

Changelog

Breaking Changes

References

openshift-ci-robot commented Nov 29, 2023

tremes commented Nov 29, 2023

tremes commented Nov 29, 2023

tremes commented Nov 30, 2023

tremes commented Nov 30, 2023

tremes commented Dec 1, 2023

openshift-ci-robot commented Dec 1, 2023

tremes commented Dec 1, 2023

openshift-ci bot commented Dec 1, 2023

openshift-ci bot commented Dec 1, 2023

openshift-bot commented Dec 1, 2023

tremes commented Nov 2, 2023 •

edited

Loading

openshift-ci-robot commented Nov 27, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 29, 2023 •

edited by openshift-ci bot

Loading