Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: gather new insights-config CM & add warning for deprecated support se… #878

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Dec 5, 2023

…cret

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/configmaps/openshift-insights/insights-config/config.json

Documentation

  • docs/gathered-data.md

Unit Tests

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 5, 2023
@openshift-ci-robot
Copy link
Contributor

@tremes: This pull request explicitly references no jira issue.

In response to this:

…cret

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/configmaps/openshift-insights/insights-config/config.json

Documentation

  • docs/gathered-data.md

Unit Tests

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from ncaak and rhrmo December 5, 2023 11:11
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2023
@tremes
Copy link
Contributor Author

tremes commented Dec 5, 2023

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Copy link

openshift-ci bot commented Dec 5, 2023

@tremes: Overrode contexts on behalf of tremes: ci/prow/e2e-metal-ipi-ovn-ipv6

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes
Copy link
Contributor Author

tremes commented Dec 6, 2023

/test insights-operator-e2e-tests

1 similar comment
@tremes
Copy link
Contributor Author

tremes commented Dec 7, 2023

/test insights-operator-e2e-tests

Copy link
Contributor

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2023
Copy link

openshift-ci bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rluders, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tremes
Copy link
Contributor Author

tremes commented Dec 7, 2023

/test insights-operator-e2e-tests

@JoaoFula
Copy link
Contributor

JoaoFula commented Dec 7, 2023

Verified gathering and verified warning. Thank you

@JoaoFula
Copy link
Contributor

JoaoFula commented Dec 7, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Dec 7, 2023
Copy link

openshift-ci bot commented Dec 7, 2023

@tremes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2e6175f into openshift:master Dec 7, 2023
9 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-insights-operator-container-v4.15.0-202312071813.p0.g2e6175f.assembly.stream for distgit ose-insights-operator.
All builds following this will include this PR.

rluders pushed a commit to rluders/insights-operator that referenced this pull request Dec 12, 2023
JoaoFula pushed a commit to JoaoFula/insights-operator that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants