Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-23616: changelog script - parse arguments as time #882

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Dec 7, 2023

This is attempt to fix the SAST warning:

 Unsanitized input from a CLI argument flows into net.http.NewRequestWithContext, where it is used as an URL to perform a request. This may result in a Server-Side Request Forgery vulnerability.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

no new data

Documentation

Unit Tests

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/OCPBUGS-23616
https://access.redhat.com/solutions/???

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 7, 2023
@openshift-ci-robot
Copy link
Contributor

@tremes: This pull request references Jira Issue OCPBUGS-23616, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This attempt to fix the SAST warning:

Unsanitized input from a CLI argument flows into net.http.NewRequestWithContext, where it is used as an URL to perform a request. This may result in a Server-Side Request Forgery vulnerability.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

no new data

Documentation

Unit Tests

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/OCPBUGS-23616
https://access.redhat.com/solutions/???

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from rhrmo and rluders December 7, 2023 11:28
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2023
@tremes
Copy link
Contributor Author

tremes commented Dec 7, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 7, 2023
@openshift-ci-robot
Copy link
Contributor

@tremes: This pull request references Jira Issue OCPBUGS-23616, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @JoaoFula

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes
Copy link
Contributor Author

tremes commented Dec 7, 2023

/override ci/prow/e2e-metal-ipi-ovn-ipv6

@openshift-ci openshift-ci bot requested a review from JoaoFula December 7, 2023 14:17
Copy link

openshift-ci bot commented Dec 7, 2023

@tremes: Overrode contexts on behalf of tremes: ci/prow/e2e-metal-ipi-ovn-ipv6

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoaoFula
Copy link
Contributor

JoaoFula commented Dec 8, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Dec 8, 2023
@openshift-ci-robot
Copy link
Contributor

@tremes: This pull request references Jira Issue OCPBUGS-23616, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @JoaoFula

In response to this:

This is attempt to fix the SAST warning:

Unsanitized input from a CLI argument flows into net.http.NewRequestWithContext, where it is used as an URL to perform a request. This may result in a Server-Side Request Forgery vulnerability.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

no new data

Documentation

Unit Tests

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/OCPBUGS-23616
https://access.redhat.com/solutions/???

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2023
Copy link

openshift-ci bot commented Dec 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rluders, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2e6175f and 2 for PR HEAD cb42803 in total

@openshift-bot
Copy link
Contributor

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

@tremes
Copy link
Contributor Author

tremes commented Dec 8, 2023

/test insights-operator-e2e-tests

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d1f4557 and 1 for PR HEAD cb42803 in total

@tremes
Copy link
Contributor Author

tremes commented Dec 11, 2023

This is a minor change for the changelog script.
/override ci/prow/insights-operator-e2e-tests

Copy link

openshift-ci bot commented Dec 11, 2023

@tremes: Overrode contexts on behalf of tremes: ci/prow/insights-operator-e2e-tests

In response to this:

This is a minor change for the changelog script.
/override ci/prow/insights-operator-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes
Copy link
Contributor Author

tremes commented Dec 11, 2023

/override ci/prow/e2e
/override ci/prow/e2e-agnostic-upgrade
/override ci/prow/e2e-gcp-ovn-techpreview

Copy link

openshift-ci bot commented Dec 11, 2023

@tremes: Overrode contexts on behalf of tremes: ci/prow/e2e, ci/prow/e2e-agnostic-upgrade, ci/prow/e2e-gcp-ovn-techpreview

In response to this:

/override ci/prow/e2e
/override ci/prow/e2e-agnostic-upgrade
/override ci/prow/e2e-gcp-ovn-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit a8a80ec into openshift:master Dec 11, 2023
9 checks passed
@openshift-ci-robot
Copy link
Contributor

@tremes: Jira Issue OCPBUGS-23616: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-23616 has been moved to the MODIFIED state.

In response to this:

This is attempt to fix the SAST warning:

Unsanitized input from a CLI argument flows into net.http.NewRequestWithContext, where it is used as an URL to perform a request. This may result in a Server-Side Request Forgery vulnerability.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

no new data

Documentation

Unit Tests

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/OCPBUGS-23616
https://access.redhat.com/solutions/???

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Dec 11, 2023

@tremes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-insights-operator-container-v4.16.0-202312110932.p0.ga8a80ec.assembly.stream for distgit ose-insights-operator.
All builds following this will include this PR.

rluders pushed a commit to rluders/insights-operator that referenced this pull request Dec 12, 2023
JoaoFula pushed a commit to JoaoFula/insights-operator that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants