NO-JIRA: manifests: bump loglevel of operator to normal #895
Conversation
Signed-off-by: lan.tian <lance5890@163.com>
openshift-ci-robot
added
the
jira/valid-reference
|
@lance5890: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @lance5890. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cc @tremes |
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance5890, tremes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
@lance5890 we will need to either udpate/fix our tests or update the log level of some corresponding messages. Do you know what the default level (from the https://github.com/openshift/api/blob/master/operator/v1/types.go#L65) is equal to in terms of klog level https://github.com/kubernetes/klog/blob/main/klog.go#L1365? |
maybe u can read this https://github.com/openshift/library-go/blob/2ad786549f07f264339f63b12b71a0fe5e77e832/pkg/operator/loglevel/util.go#L14-L27 the default operator loglevel is Normal, which is eqaul to v(2) |
|
/retest-required |
1 similar comment
|
/retest-required |
|
@lance5890 stop retesting please. We need to update the tests first as mentioned above. |
|
/retest |
|
/label qe-approved |
|
/test insights-operator-e2e-tests |
openshift-ci
bot
added
the
qe-approved
|
/test insights-operator-e2e-tests |
5 similar comments
|
/test insights-operator-e2e-tests |
|
/test insights-operator-e2e-tests |
|
/test insights-operator-e2e-tests |
|
/test insights-operator-e2e-tests |
|
/test insights-operator-e2e-tests |
|
/lgtm |
|
@lance5890: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-insights-operator-container-v4.16.0-202402160210.p0.gac7704e.assembly.stream.el9 for distgit ose-insights-operator. |
This PR implements a new data enhancement to...
with the #894 loglevel controller has merged, we can remove the loglevel in manifests, which now is already controlled by loglevel controller and is set on Normal by default
Categories
Sample Archive
path/to/sample_data.jsonDocumentation
path/to/documentation.mdUnit Tests
path/to/file_test.goPrivacy
Yes. There are no sensitive data in the newly collected information.
Changelog
Breaking Changes
Yes/No
References
https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???