OCPBUGS-35727: Ingress controller related certificates' validate dates gathering #945
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@ncaak: This pull request references CCXDEV-12503 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncaak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
pkg/gatherers/clusterconfig/gather_cluster_ingress_certificates.go
Outdated
Show resolved
Hide resolved
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
pkg/gatherers/clusterconfig/gather_cluster_ingress_certificates.go
Outdated
Show resolved
Hide resolved
pkg/gatherers/clusterconfig/gather_cluster_ingress_certificates.go
Outdated
Show resolved
Hide resolved
pkg/gatherers/clusterconfig/gather_cluster_ingress_certificates.go
Outdated
Show resolved
Hide resolved
pkg/gatherers/clusterconfig/gather_cluster_ingress_certificates.go
Outdated
Show resolved
Hide resolved
|
@ncaak: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| } | ||
|
|
||
| var ci []*CertificateInfo | ||
| if len(certificatesInfo) > 0 { |
There was a problem hiding this comment.
This is also not necessary, but let's not run the CI again :)
There was a problem hiding this comment.
Aw yeah... After the refactor of the inner code the conditional is of no use :(
I'll leave it marked in my local repo for the next PR to include it as an improvement. Thanks.
|
Looks mostly good and seems to work OK :) |
ncaak
changed the title
|
@ncaak: This pull request references Jira Issue OCPBUGS-35727, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-bug
|
@ncaak: Jira Issue OCPBUGS-35727: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-35727 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-insights-operator-container-v4.17.0-202406181442.p0.gb718b24.assembly.stream.el9 for distgit ose-insights-operator. |
|
/jira backport release-4.16,release-4.15,release-4.14 |
|
@ncaak: The following backport issues have been created:
Queuing cherrypicks to the requested branches to be created after this PR merges: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: new pull request created: #970 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR continues the work of #917