Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-36687: Start collecting haproxy_exporter_server_threshold metric #963

Conversation

ncaak
Copy link
Contributor

@ncaak ncaak commented Jul 8, 2024

Added haproxy_exporter_server_threshold metric to GatherMostRecentMetrics gatherer

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/metrics

Documentation

  • docs/gathered-data.md

Unit Tests

  • path/to/file_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-13001
https://issues.redhat.com/browse/OCPBUGS-36687

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2024
Copy link

openshift-ci bot commented Jul 8, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ncaak ncaak changed the title OCPBUGS-xxxx: Start collecting haproxy_exporter_server_threshold metric OCPBUGS-36687: Start collecting haproxy_exporter_server_threshold metric Jul 8, 2024
@ncaak ncaak marked this pull request as ready for review July 8, 2024 14:35
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 8, 2024
@openshift-ci-robot
Copy link
Contributor

@ncaak: This pull request references Jira Issue OCPBUGS-36687, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @BaiyangZhou

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Added haproxy_exporter_server_threshold metric to GatherMostRecentMetrics gatherer

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/metrics

Documentation

  • docs/gathered-data.md

Unit Tests

  • path/to/file_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-13001
https://issues.redhat.com/browse/OCPBUGS-36687

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from BaiyangZhou July 8, 2024 14:36
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2024
Copy link

openshift-ci bot commented Jul 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2024
@openshift-ci openshift-ci bot requested review from rhrmo and tremes July 8, 2024 14:47
@ncaak
Copy link
Contributor Author

ncaak commented Jul 8, 2024

/retest

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 9, 2024
@tremes
Copy link
Contributor

tremes commented Jul 9, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2024
@BaiyangZhou
Copy link

/remove-label cherry-pick-approved

@openshift-ci openshift-ci bot removed the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 9, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD f7c5ffd and 2 for PR HEAD b4cf943 in total

Copy link

openshift-ci bot commented Jul 9, 2024

@ncaak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e516729 into openshift:master Jul 9, 2024
9 checks passed
@openshift-ci-robot
Copy link
Contributor

@ncaak: Jira Issue OCPBUGS-36687: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36687 has been moved to the MODIFIED state.

In response to this:

Added haproxy_exporter_server_threshold metric to GatherMostRecentMetrics gatherer

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/metrics

Documentation

  • docs/gathered-data.md

Unit Tests

  • path/to/file_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-13001
https://issues.redhat.com/browse/OCPBUGS-36687

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-insights-operator-container-v4.17.0-202407091212.p0.ge516729.assembly.stream.el9 for distgit ose-insights-operator.
All builds following this will include this PR.

@ncaak
Copy link
Contributor Author

ncaak commented Aug 9, 2024

/jira backport release-4.16,release-4.15,release-4.14

@openshift-ci-robot
Copy link
Contributor

@ncaak: Missing required branches for backport chain:

  • openshift-4.17 OR release-4.17,

In response to this:

/jira backport release-4.16,release-4.15,release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ncaak
Copy link
Contributor Author

ncaak commented Aug 9, 2024

/cherrypick release-4.16

@openshift-cherrypick-robot

@ncaak: new pull request created: #977

In response to this:

/cherrypick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants