Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-39111: collect some nmstate customresources #986

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Aug 28, 2024

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/cluster-scoped-resources/nmstate.io/nodenetworkconfigurationpolicies/policy-name.json
  • docs/insights-archive-sample/cluster-scoped-resources/nmstate.io/nodenetworkstates/ip-10-0-21-41.us-east-2.compute.internal.json
  • docs/insights-archive-sample/cluster-scoped-resources/nmstate.io/nodenetworkstates/ip-10-0-24-83.us-east-2.compute.internal.json
  • docs/insights-archive-sample/cluster-scoped-resources/nmstate.io/nodenetworkstates/ip-10-0-42-30.us-east-2.compute.internal.json
  • docs/insights-archive-sample/cluster-scoped-resources/nmstate.io/nodenetworkstates/ip-10-0-61-249.us-east-2.compute.internal.json

Documentation

  • docs/gathered-data.md

Unit Tests

  • pkg/gatherers/clusterconfig/gather_nmstate_node_network_configuration_policy_test.go
  • pkg/gatherers/clusterconfig/gather_nmstate_nodenetworkstate_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/OCPBUGS-39111
https://issues.redhat.com/browse/CCXDEV-14148
https://access.redhat.com/solutions/???

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 28, 2024
@openshift-ci-robot
Copy link
Contributor

@tremes: This pull request references Jira Issue OCPBUGS-39111, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/cluster-scoped-resources/nmstate.io/nodenetworkconfigurationpolicies/policy-name.json
  • docs/insights-archive-sample/cluster-scoped-resources/nmstate.io/nodenetworkstates/ip-10-0-21-41.us-east-2.compute.internal.json
  • docs/insights-archive-sample/cluster-scoped-resources/nmstate.io/nodenetworkstates/ip-10-0-24-83.us-east-2.compute.internal.json
  • docs/insights-archive-sample/cluster-scoped-resources/nmstate.io/nodenetworkstates/ip-10-0-42-30.us-east-2.compute.internal.json
  • docs/insights-archive-sample/cluster-scoped-resources/nmstate.io/nodenetworkstates/ip-10-0-61-249.us-east-2.compute.internal.json

Documentation

  • docs/gathered-data.md

Unit Tests

  • pkg/gatherers/clusterconfig/gather_nmstate_node_network_configuration_policy_test.go
  • pkg/gatherers/clusterconfig/gather_nmstate_nodenetworkstate_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/OCPBUGS-39111
https://issues.redhat.com/browse/CCXDEV-14148
https://access.redhat.com/solutions/???

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from ncaak August 28, 2024 10:57
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2024
@tremes
Copy link
Contributor Author

tremes commented Aug 28, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 28, 2024
@openshift-ci-robot
Copy link
Contributor

@tremes: This pull request references Jira Issue OCPBUGS-39111, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @BaiyangZhou

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from BaiyangZhou August 28, 2024 11:01
@BaiyangZhou
Copy link

IO-test failures analyze:
image

Copy link
Contributor

@ncaak ncaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2024
Copy link

openshift-ci bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a54c722 and 2 for PR HEAD a6399a0 in total

7 similar comments
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a54c722 and 2 for PR HEAD a6399a0 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a54c722 and 2 for PR HEAD a6399a0 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a54c722 and 2 for PR HEAD a6399a0 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a54c722 and 2 for PR HEAD a6399a0 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a54c722 and 2 for PR HEAD a6399a0 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a54c722 and 2 for PR HEAD a6399a0 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a54c722 and 2 for PR HEAD a6399a0 in total

@tremes
Copy link
Contributor Author

tremes commented Aug 30, 2024

/retest

1 similar comment
@tremes
Copy link
Contributor Author

tremes commented Aug 30, 2024

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a54c722 and 2 for PR HEAD a6399a0 in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a54c722 and 2 for PR HEAD a6399a0 in total

@tremes
Copy link
Contributor Author

tremes commented Sep 2, 2024

/retest

@tremes
Copy link
Contributor Author

tremes commented Sep 2, 2024

/test insights-operator-e2e-tests

@tremes
Copy link
Contributor Author

tremes commented Sep 3, 2024

/retest

@tremes
Copy link
Contributor Author

tremes commented Sep 3, 2024

Test failures are about missing file in the archive, but it's not related to this change
/override ci/prow/insights-operator-e2e-tests

Copy link

openshift-ci bot commented Sep 3, 2024

@tremes: Overrode contexts on behalf of tremes: ci/prow/insights-operator-e2e-tests

In response to this:

Test failures are about missing file in the archive, but it's not related to this change
/override ci/prow/insights-operator-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Sep 3, 2024

@tremes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 7bf4b55 into openshift:master Sep 3, 2024
9 checks passed
@openshift-ci-robot
Copy link
Contributor

@tremes: Jira Issue OCPBUGS-39111: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-39111 has been moved to the MODIFIED state.

In response to this:

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/cluster-scoped-resources/nmstate.io/nodenetworkconfigurationpolicies/policy-name.json
  • docs/insights-archive-sample/cluster-scoped-resources/nmstate.io/nodenetworkstates/ip-10-0-21-41.us-east-2.compute.internal.json
  • docs/insights-archive-sample/cluster-scoped-resources/nmstate.io/nodenetworkstates/ip-10-0-24-83.us-east-2.compute.internal.json
  • docs/insights-archive-sample/cluster-scoped-resources/nmstate.io/nodenetworkstates/ip-10-0-42-30.us-east-2.compute.internal.json
  • docs/insights-archive-sample/cluster-scoped-resources/nmstate.io/nodenetworkstates/ip-10-0-61-249.us-east-2.compute.internal.json

Documentation

  • docs/gathered-data.md

Unit Tests

  • pkg/gatherers/clusterconfig/gather_nmstate_node_network_configuration_policy_test.go
  • pkg/gatherers/clusterconfig/gather_nmstate_nodenetworkstate_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/OCPBUGS-39111
https://issues.redhat.com/browse/CCXDEV-14148
https://access.redhat.com/solutions/???

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tremes
Copy link
Contributor Author

tremes commented Sep 3, 2024

/jira backport release-4.17, release-4.16, release-4.15

@tremes
Copy link
Contributor Author

tremes commented Sep 3, 2024

/jira backport release-4.17,release-4.16,release-4.15

@openshift-ci-robot
Copy link
Contributor

@tremes: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.17
/cherrypick release-4.16
/cherrypick release-4.15

In response to this:

/jira backport release-4.17,release-4.16,release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@openshift-ci-robot: #986 failed to apply on top of branch "release-4.17":

Applying: OCPBUGS-39111: collect some nmstate customresources
.git/rebase-apply/patch:4408: trailing whitespace.
      interfaces: 
.git/rebase-apply/patch:4428: trailing whitespace.
      interfaces: 
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	docs/gathered-data.md
Falling back to patching base and 3-way merge...
Auto-merging docs/gathered-data.md
CONFLICT (content): Merge conflict in docs/gathered-data.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-39111: collect some nmstate customresources
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

@tremes: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.17
/cherrypick release-4.16
/cherrypick release-4.15

In response to this:

/jira backport release-4.17,release-4.16,release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tremes added a commit to tremes/insights-operator that referenced this pull request Sep 3, 2024
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-insights-operator
This PR has been included in build ose-insights-operator-container-v4.18.0-202409031742.p0.g7bf4b55.assembly.stream.el9.
All builds following this will include this PR.

tremes added a commit to tremes/insights-operator that referenced this pull request Sep 9, 2024
tremes added a commit to tremes/insights-operator that referenced this pull request Sep 10, 2024
tremes added a commit to tremes/insights-operator that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants