Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.5] Bug 1853400: templates: add node-valid-hostname.service for hostname check #1901

Closed
wants to merge 1 commit into from
Closed

[release-4.5] Bug 1853400: templates: add node-valid-hostname.service for hostname check #1901

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1813

/assign miabbott

templates: add node-valid-hostname.service for hostname check
f6b2c2a 
This seeks to address the problem with "localhost" nodes attempting to
join a cluster by holding up network-online.target until the node gets a
valid hostname (not localhost).

Bug 1845885: race condition during installation between nodes getting their
             hostnames and crio+kubelet starting

Signed-off-by: Ben Howard <ben.howard@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 6, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Detected clone of Bugzilla bug 1845885 with correct target release. Retitling PR to link to clone:
/retitle [release-4.5] Bug 1853400: templates: add node-valid-hostname.service for hostname check

In response to this:

[release-4.5] Bug 1845885: templates: add node-valid-hostname.service for hostname check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.5] Bug 1845885: templates: add node-valid-hostname.service for hostname check [release-4.5] Bug 1853400: templates: add node-valid-hostname.service for hostname check Jul 6, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 6, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1853400, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1845885 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1845885 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

[release-4.5] Bug 1853400: templates: add node-valid-hostname.service for hostname check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ashcrow
Copy link
Member

ashcrow commented Jul 6, 2020

/test e2e-aws

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2020
@miabbott
Copy link
Member

miabbott commented Jul 6, 2020 •
edited
Loading

e2e-aws is failing on:

[sig-instrumentation] Prometheus when installed on the cluster should report telemetry if a cloud.openshift.com token is present [Suite:openshift/conformance/parallel]

According to sippy, that's passing 85% of the time and is associated with https://bugzilla.redhat.com/show_bug.cgi?id=1853007

@miabbott
Copy link
Member

miabbott commented Jul 6, 2020

/retest e2e-aws

@openshift-ci-robot
Copy link
Contributor

@miabbott: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

  • /test e2e-aws
  • /test e2e-aws-disruptive
  • /test e2e-aws-scaleup-rhel7
  • /test e2e-azure
  • /test e2e-gcp-op
  • /test e2e-gcp-upgrade
  • /test e2e-metal-ipi
  • /test e2e-ovirt
  • /test e2e-ovn-step-registry
  • /test e2e-vsphere
  • /test e2e-vsphere-upi
  • /test images
  • /test unit
  • /test verify

Use /test all to run the following jobs:

  • pull-ci-openshift-machine-config-operator-release-4.5-e2e-aws
  • pull-ci-openshift-machine-config-operator-release-4.5-e2e-aws-scaleup-rhel7
  • pull-ci-openshift-machine-config-operator-release-4.5-e2e-gcp-op
  • pull-ci-openshift-machine-config-operator-release-4.5-e2e-gcp-upgrade
  • pull-ci-openshift-machine-config-operator-release-4.5-e2e-metal-ipi
  • pull-ci-openshift-machine-config-operator-release-4.5-e2e-ovn-step-registry
  • pull-ci-openshift-machine-config-operator-release-4.5-images
  • pull-ci-openshift-machine-config-operator-release-4.5-unit
  • pull-ci-openshift-machine-config-operator-release-4.5-verify

In response to this:

/retest e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@miabbott
Copy link
Member

miabbott commented Jul 6, 2020

/test e2e-aws

@darkmuggle
Copy link
Contributor

This blocks the backport of #1914

/test e2e-aws-scaleup-rhel7

@runcom
Copy link
Member

runcom commented Jul 21, 2020

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, openshift-cherrypick-robot, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2020
@darkmuggle
Copy link
Contributor

Dropping in favor of #1939 which includes all the fixes, including this one.

@darkmuggle darkmuggle closed this Jul 21, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1853400. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

[release-4.5] Bug 1853400: templates: add node-valid-hostname.service for hostname check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashcrow ashcrow ashcrow approved these changes

@cgwalters cgwalters Awaiting requested review from cgwalters

Assignees

@runcom runcom

@miabbott miabbott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@openshift-cherrypick-robot @openshift-ci-robot @ashcrow @miabbott @darkmuggle @runcom