operator: refactor bootstrapping to allow non-bootstrap manifests #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/L
Contributor
Author
|
/retest |
Contributor
Author
|
/test images |
Contributor
Author
|
/test e2e-aws |
Member
|
Can you elaborate slightly on what problem this is solving? |
Member
|
/test e2e-aws |
1 similar comment
Member
|
/test e2e-aws |
abhinavdahiya
force-pushed
the
master_bootstrapping
branch
from
983e37f to
ea56836
Compare
abhinavdahiya
added a commit
to abhinavdahiya/installer
that referenced
this pull request
Dec 11, 2018
openshift/machine-config-operator#226 sets up all the `manifests` required to approve CSRs for masters
Contributor
Author
updated the PR description. |
Contributor
Author
|
/retest |
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, ashcrow The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/test e2e-aws |
osherdp
pushed a commit
to osherdp/machine-config-operator
that referenced
this pull request
Apr 13, 2021
Bug 1788676: keep tbr inaccessible clusteroperator reason set (bootstrap removed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows MCO bootstrap to render manifests in
/mainfeststhat are pushed to cluster using bootstrap node.MCO in bootstrap mode has 3 sets of assets.
bootstrap/manifests-> used by bootstrap MCC.bootstrap- > MCC+MCS bootstrap pod.manifests- > manifests installed during cluster bootstrap. eg the clusterrolebindings to allow master node boostrapping.Previously MCO in bootstrap mode only supported 1 and 3. This PR allows all three.
The MCC+MCS bootstrap pod has a
v2to support all the directory changes.See: openshift/installer#879 why this was needed in the first place.