OCPBUGS-65851: Fixes ImagePruner error wrapping

[cheesesashimi]

- What I did

This removes ErrImage wrapping / detection from the acceptable error path in favor of directly inspecting the errors returned since the needed information is already there. However, we keep ErrImage wrapping in place so that we can ensure that the image name is associated with the error.

- How to verify it

The e2e tests which depend on correct error identification such as TestImagePruner, TestMissingImageIsRebuilt, etc. should now pass.

- Description for the changelog
Fixes ImagePruner error wrapping

[cheesesashimi]

/test unit verify e2e-gcp-op-ocl

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cheesesashimi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@cheesesashimi: This pull request references Jira Issue OCPBUGS-65851, which is invalid:

• expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

- What I did

This removes ErrImage wrapping / detection from the acceptable error
path in favor of directly inspecting the errors returned. However, we
keep ErrImage wrapping in place so that we can ensure that the image
name is associated with the error.

- How to verify it

The e2e tests which depend on correct error identification such as
TestImagePruner, TestMissingImageIsRebuilt, etc. should now pass.

- Description for the changelog
Fixes ImagePruner error wrapping

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[cheesesashimi]

/jira refresh

[openshift-ci-robot]

@cheesesashimi: This pull request references Jira Issue OCPBUGS-65851, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[cheesesashimi]

/test unit
/test verify
/test e2e-gcp-op-ocl

[openshift-ci-robot]

@cheesesashimi: This pull request references Jira Issue OCPBUGS-65851, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

- What I did

This removes ErrImage wrapping / detection from the acceptable error path in favor of directly inspecting the errors returned since the needed information is already there. However, we keep ErrImage wrapping in place so that we can ensure that the image name is associated with the error.

- How to verify it

The e2e tests which depend on correct error identification such as TestImagePruner, TestMissingImageIsRebuilt, etc. should now pass.

- Description for the changelog
Fixes ImagePruner error wrapping

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[cheesesashimi]

/test e2e-gcp-op-ocl

[openshift-ci]

@cheesesashimi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-op-ocl	ac406f3	link	false	/test e2e-gcp-op-ocl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.