-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-20151: [CHERRY PICK FROM UPSTREAM]: Take optional attributes into account for fibre_channel metrics #144
Conversation
take into account optional attributes
@machine424: This pull request references Jira Issue OCPBUGS-20151, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jan--f, machine424 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@machine424: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/jira refresh |
@machine424: This pull request references Jira Issue OCPBUGS-20151, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@machine424: Jira Issue OCPBUGS-20151: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-20151 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build golang-github-prometheus-node_exporter-container-v4.16.0-202404241818.p0.g6abe034.assembly.stream.el9 for distgit golang-github-prometheus-node_exporter. |
update github.com/prometheus/procfs to v0.13.0 for fibre_channel to
take into account optional attributes
Updates procfs to get: prometheus/procfs#607, other notable changes in v0.13.0: https://github.com/prometheus/procfs/releases/tag/v0.13.0
Cherry-picked prometheus#2933 from node-exporter to get the tests
A new version of upstream node exporter with github.com/prometheus/procfs to v0.13.0 isn't available yet.