Bug 1958080: Add missing error page strings #77
Conversation
|
@jhadvig: This pull request references Bugzilla bug 1958080, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/severity-high
| @@ -134,7 +134,7 @@ func (l *Login) handleLoginForm(w http.ResponseWriter, req *http.Request) { | |||
| form.Locale = locales.GetLocale(req.Header.Get("Accept-Language")) | |||
| form.ErrorCode = req.URL.Query().Get(reasonParam) | |||
| if len(form.ErrorCode) > 0 { | |||
| if msg, hasMsg := errorMessages[form.ErrorCode]; hasMsg { | |||
| if msg, hasMsg := form.Locale[errorMessages[form.ErrorCode]]; hasMsg { | |||
|
/lgtm |
|
/hold |
openshift-ci
bot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig, stlaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Successfully verified that the fix is working. Removing
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test e2e-agnostic-upgrade |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@jhadvig: All pull requests linked via external trackers have merged: Bugzilla bug 1958080 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sent the translations to the localization team, with help of @rebeccaalpert ...will update once they come.
/assign @stlaz
cc'ing @sg00dwin