-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONSOLE-2535: Translation of login templates #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to move or add raw
tags to encompass anything that needs to be process by the server.
Also need to account for |
I put up a PR with these fixes. sg00dwin#1 |
45b61c0
to
8ab728e
Compare
8ab728e
to
b650afc
Compare
Would be good to add the following at https://github.com/openshift/oauth-templates/blame/master/README.md#L81 since the secret is now managed by
|
b650afc
to
b879cba
Compare
Whoops. I forgot to mention we need to update the undo instructions, too. Add the following at the bottom of README.md.
|
@sg00dwin ^^ |
c129c59
to
9b728ec
Compare
README additions added to pr |
25e8775
to
78d99de
Compare
Switch title separator from dash to dot for consistency with rest of console relates to openshift/oauth-server#71 update README testing instructions.
78d99de
to
a75332d
Compare
relates to openshift/oauth-server#71