Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONSOLE-2535: Translation of login templates #15

Merged
merged 1 commit into from
May 10, 2021

Conversation

sg00dwin
Copy link
Member

@sg00dwin sg00dwin changed the title Translation of login templates console 2535 story [WIP] Translation of login templates console 2535 Mar 29, 2021
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 29, 2021
@jhadvig jhadvig self-assigned this Mar 30, 2021
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to move or add raw tags to encompass anything that needs to be process by the server.

_layouts/login.html Outdated Show resolved Hide resolved
_layouts/login.html Outdated Show resolved Hide resolved
_layouts/login.html Outdated Show resolved Hide resolved
_layouts/login.html Outdated Show resolved Hide resolved
_layouts/login.html Outdated Show resolved Hide resolved
@rhamilto
Copy link
Member

rhamilto commented Mar 30, 2021

Also need to account for {{page.title}} in https://github.com/openshift/oauth-templates/blob/master/_includes/head.html#L2 . And I notice we use · as the separator in the console's <title> instead of -. We should probably match the console here.

@rhamilto
Copy link
Member

I put up a PR with these fixes. sg00dwin#1

@sg00dwin sg00dwin force-pushed the translation-console-2535 branch 2 times, most recently from 45b61c0 to 8ab728e Compare March 31, 2021 15:29
@jhadvig jhadvig changed the title [WIP] Translation of login templates console 2535 Translation of login templates console 2535 Apr 6, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 6, 2021
@jhadvig jhadvig changed the title Translation of login templates console 2535 CONSOLE-2535: Translation of login templates console 2535 Apr 6, 2021
@sg00dwin sg00dwin changed the title CONSOLE-2535: Translation of login templates console 2535 CONSOLE-2535: Translation of login templates Apr 30, 2021
@sg00dwin sg00dwin force-pushed the translation-console-2535 branch from 8ab728e to b650afc Compare May 3, 2021 20:59
@rhamilto
Copy link
Member

rhamilto commented May 4, 2021

Would be good to add the following at https://github.com/openshift/oauth-templates/blame/master/README.md#L81 since the secret is now managed by authentication-operator.

1. Scale `authentication-operator` to zero pods in the web console by visiting `http://<HOSTNAME>/k8s/ns/openshift-authentication-operator/deployments/authentication-operator` and using the pod donut controls to set pods to zero. 

@sg00dwin sg00dwin force-pushed the translation-console-2535 branch from b650afc to b879cba Compare May 4, 2021 21:13
@rhamilto
Copy link
Member

rhamilto commented May 4, 2021

Whoops. I forgot to mention we need to update the undo instructions, too. Add the following at the bottom of README.md.

1. Visit `http://<HOSTNAME>/k8s/ns/openshift-authentication-operator/deployments/authentication-operator` and use the pod donut controls to set pods to one.

@jhadvig
Copy link
Member

jhadvig commented May 5, 2021

@sg00dwin ^^

@sg00dwin sg00dwin force-pushed the translation-console-2535 branch 2 times, most recently from c129c59 to 9b728ec Compare May 5, 2021 15:04
@sg00dwin
Copy link
Member Author

sg00dwin commented May 5, 2021

README additions added to pr

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@sg00dwin sg00dwin force-pushed the translation-console-2535 branch 2 times, most recently from 25e8775 to 78d99de Compare May 5, 2021 15:10
Switch title separator from dash to dot for consistency with rest of console
relates to openshift/oauth-server#71
update README testing instructions.
@sg00dwin sg00dwin force-pushed the translation-console-2535 branch from 78d99de to a75332d Compare May 5, 2021 15:36
@openshift openshift deleted a comment from rhamilto May 10, 2021
@rhamilto rhamilto merged commit ba8b6ed into openshift:master May 10, 2021
@sg00dwin sg00dwin deleted the translation-console-2535 branch May 10, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants