Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSDOCS-1770 Installing a cluster on GCP in a restricted network #32482

Merged
merged 1 commit into from
May 13, 2021

Conversation

codyhoag
Copy link
Contributor

@codyhoag codyhoag commented May 12, 2021

@codyhoag codyhoag added this to the Next Release milestone May 12, 2021
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 12, 2021
@netlify
Copy link

netlify bot commented May 12, 2021

Deploy preview for osdocs ready!

Built with commit f591cba

https://deploy-preview-32482--osdocs.netlify.app

@codyhoag codyhoag force-pushed the gcp-restricted-network branch from 731983e to 7e53f4c Compare May 12, 2021 15:05
@codyhoag
Copy link
Contributor Author

@staebler PTAL. I followed a similar path as what was recommended for AWS. Thanks!

Copy link

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codyhoag
Copy link
Contributor Author

@tsze-redhat can you confirm from a QE perspective? Thanks!

@tsze-redhat
Copy link

Is this for adding a page for IPI Restricted cluster?

Assuming it is,
1 why do we need an existing vpc?

2 Item 12 in
https://deploy-preview-32482--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_gcp/installing-restricted-networks-gcp-installer-provisioned.html#installation-gcp-config-yaml_installing-restricted-networks-gcp-installer-provisioned

under
additionalTrustBundle: |
-----BEGIN CERTIFICATE-----
<MY_TRUSTED_CA_CERT>
-----END CERTIFICATE-----

texts need to have two spaces from beginning.

Right now, there appears to be 4.

Can you confirm?

3 Hyperthreading for compute under
compute:

  • hyperthreading: Enabled

is marked as remark #3 only but it should be #3 & #4 (similar to control).

4 Configuring the cluster-wide proxy during installation should be optional
https://deploy-preview-32482--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_gcp/installing-restricted-networks-gcp-installer-provisioned.html#installation-configure-proxy_installing-restricted-networks-gcp-installer-provisioned

In fact, why do we have this section?
It is not there in Restricted network UPI page.

This section only appears in "Installing a cluster on GCP into an existing VPC" page.

Please feel free to ping me if you need any clarification on any of the above.

Thanks.

@codyhoag codyhoag force-pushed the gcp-restricted-network branch from 7e53f4c to 3901633 Compare May 12, 2021 17:59
@codyhoag
Copy link
Contributor Author

codyhoag commented May 12, 2021

@tsze-redhat a few answers below:

Is this for adding a page for IPI Restricted cluster?

Yes

  1. why do we need an existing vpc?

Matthew explained it well here. A snippet from his explanation to me: The point of needing to BYO VPC is that either (1) the mirror registry needs to be in the VPC or (2) the VPC needs to have firewall rules or peering to access the mirror registry hosted elsewhere. In either case, the VPC needs to exist before installation.

  1. texts need to have two spaces from beginning. Right now, there appears to be 4.

Fixed

  1. Hyperthreading for compute is marked as remark Initial build system #3 only but it should be Initial build system #3 & Fixed doc files to meet AsciiDoctor standards #4 (similar to control).

Fixed

  1. Configuring the cluster-wide proxy during installation should be optional. In fact, why do we have this section? It is not there in Restricted network UPI page.

I've been putting this in the restricted assemblies based on feedback I receieved during the vSphere review process from Jinyun here. From what I understand, this used to not be supported for IPI installs, but is now supported as of recently. I'm not sure why it is not there for GCP UPI, but I can add it there in a separate PR if that would be relevant there.

Let me know if there's any other feedback or any changes for this. Thanks!

@tsze-redhat
Copy link

Given that user must provide vpc,
6, 7, 8 in https://deploy-preview-32482--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_gcp/installing-restricted-networks-gcp-installer-provisioned.html#installation-gcp-config-yaml_installing-restricted-networks-gcp-installer-provisioned
should not begin with "If you use an existing VPC, "

The rest is good.

Thanks.

@codyhoag codyhoag force-pushed the gcp-restricted-network branch from 3901633 to cf44568 Compare May 12, 2021 21:28
@codyhoag codyhoag added the peer-review-needed Signifies that the peer review team needs to review this PR label May 12, 2021
@maxwelldb maxwelldb self-requested a review May 12, 2021 23:25
Copy link
Contributor

@maxwelldb maxwelldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks copacetic.

I made a few comments/suggestions, but nothing major.

The list punctuation thing should be resolved prior to merging.

@maxwelldb maxwelldb added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 13, 2021
@codyhoag codyhoag force-pushed the gcp-restricted-network branch from cf44568 to f591cba Compare May 13, 2021 00:43
@codyhoag codyhoag merged commit 402a539 into openshift:master May 13, 2021
@codyhoag
Copy link
Contributor Author

/cherrypick enterprise-4.8

@codyhoag
Copy link
Contributor Author

/cherrypick enterprise-4.7

@codyhoag
Copy link
Contributor Author

/cherrypick enterprise-4.6

@codyhoag
Copy link
Contributor Author

/cherrypick enterprise-4.5

@openshift-cherrypick-robot

@codyhoag: new pull request created: #32510

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@codyhoag: new pull request created: #32511

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@codyhoag: #32482 failed to apply on top of branch "enterprise-4.6":

Applying: Installing a cluster on GCP in a restricted network
Using index info to reconstruct a base tree...
M	_topic_map.yml
A	installing/installing-preparing.adoc
M	modules/cli-installing-cli.adoc
M	modules/cluster-entitlements.adoc
M	modules/installation-about-restricted-network.adoc
M	modules/installation-configuration-parameters.adoc
M	modules/installation-configure-proxy.adoc
M	modules/installation-gcp-config-yaml.adoc
M	modules/installation-initializing.adoc
M	modules/ssh-agent-using.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/ssh-agent-using.adoc
Auto-merging modules/installation-initializing.adoc
Auto-merging modules/installation-gcp-config-yaml.adoc
CONFLICT (content): Merge conflict in modules/installation-gcp-config-yaml.adoc
Auto-merging modules/installation-configure-proxy.adoc
Auto-merging modules/installation-configuration-parameters.adoc
Auto-merging modules/installation-about-restricted-network.adoc
Auto-merging modules/cluster-entitlements.adoc
Auto-merging modules/cli-installing-cli.adoc
CONFLICT (modify/delete): installing/installing-preparing.adoc deleted in HEAD and modified in Installing a cluster on GCP in a restricted network. Version Installing a cluster on GCP in a restricted network of installing/installing-preparing.adoc left in tree.
Auto-merging _topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Installing a cluster on GCP in a restricted network
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@codyhoag: #32482 failed to apply on top of branch "enterprise-4.5":

Applying: Installing a cluster on GCP in a restricted network
Using index info to reconstruct a base tree...
M	_topic_map.yml
A	installing/installing-preparing.adoc
M	modules/cli-installing-cli.adoc
M	modules/cli-logging-in-kubeadmin.adoc
M	modules/cluster-entitlements.adoc
M	modules/installation-about-restricted-network.adoc
M	modules/installation-configuration-parameters.adoc
M	modules/installation-configure-proxy.adoc
M	modules/installation-gcp-config-yaml.adoc
M	modules/installation-initializing.adoc
M	modules/installation-launching-installer.adoc
M	modules/ssh-agent-using.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/ssh-agent-using.adoc
Auto-merging modules/installation-launching-installer.adoc
Auto-merging modules/installation-initializing.adoc
Auto-merging modules/installation-gcp-config-yaml.adoc
CONFLICT (content): Merge conflict in modules/installation-gcp-config-yaml.adoc
Auto-merging modules/installation-configure-proxy.adoc
Auto-merging modules/installation-configuration-parameters.adoc
Auto-merging modules/installation-about-restricted-network.adoc
CONFLICT (content): Merge conflict in modules/installation-about-restricted-network.adoc
Auto-merging modules/cluster-entitlements.adoc
Auto-merging modules/cli-logging-in-kubeadmin.adoc
Auto-merging modules/cli-installing-cli.adoc
CONFLICT (modify/delete): installing/installing-preparing.adoc deleted in HEAD and modified in Installing a cluster on GCP in a restricted network. Version Installing a cluster on GCP in a restricted network of installing/installing-preparing.adoc left in tree.
Auto-merging _topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Installing a cluster on GCP in a restricted network
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants