-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSDOCS-1770 Installing a cluster on GCP in a restricted network #32482
Conversation
Deploy preview for osdocs ready! Built with commit f591cba |
731983e
to
7e53f4c
Compare
@staebler PTAL. I followed a similar path as what was recommended for AWS. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tsze-redhat can you confirm from a QE perspective? Thanks! |
Is this for adding a page for IPI Restricted cluster? Assuming it is, under texts need to have two spaces from beginning. Right now, there appears to be 4. Can you confirm? 3 Hyperthreading for compute under
is marked as remark #3 only but it should be #3 & #4 (similar to control). 4 Configuring the cluster-wide proxy during installation should be optional In fact, why do we have this section? This section only appears in "Installing a cluster on GCP into an existing VPC" page. Please feel free to ping me if you need any clarification on any of the above. Thanks. |
7e53f4c
to
3901633
Compare
@tsze-redhat a few answers below:
Yes
Matthew explained it well here. A snippet from his explanation to me:
Fixed
Fixed
I've been putting this in the restricted assemblies based on feedback I receieved during the vSphere review process from Jinyun here. From what I understand, this used to not be supported for IPI installs, but is now supported as of recently. I'm not sure why it is not there for GCP UPI, but I can add it there in a separate PR if that would be relevant there. Let me know if there's any other feedback or any changes for this. Thanks! |
Given that user must provide vpc, The rest is good. Thanks. |
3901633
to
cf44568
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks copacetic.
I made a few comments/suggestions, but nothing major.
The list punctuation thing should be resolved prior to merging.
installing/installing_gcp/installing-restricted-networks-gcp-installer-provisioned.adoc
Outdated
Show resolved
Hide resolved
installing/installing_gcp/installing-restricted-networks-gcp-installer-provisioned.adoc
Outdated
Show resolved
Hide resolved
installing/installing_gcp/installing-restricted-networks-gcp-installer-provisioned.adoc
Outdated
Show resolved
Hide resolved
installing/installing_gcp/installing-restricted-networks-gcp-installer-provisioned.adoc
Outdated
Show resolved
Hide resolved
installing/installing_gcp/installing-restricted-networks-gcp-installer-provisioned.adoc
Show resolved
Hide resolved
installing/installing_gcp/installing-restricted-networks-gcp-installer-provisioned.adoc
Show resolved
Hide resolved
cf44568
to
f591cba
Compare
/cherrypick enterprise-4.8 |
/cherrypick enterprise-4.7 |
/cherrypick enterprise-4.6 |
/cherrypick enterprise-4.5 |
@codyhoag: new pull request created: #32510 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@codyhoag: new pull request created: #32511 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@codyhoag: #32482 failed to apply on top of branch "enterprise-4.6":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@codyhoag: #32482 failed to apply on top of branch "enterprise-4.5":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
https://issues.redhat.com/browse/OSDOCS-1770
Previews: