From d2782fa950207156147ef7eecfbdbf2af4aad35f Mon Sep 17 00:00:00 2001 From: Jordan Liggitt Date: Thu, 15 Jun 2017 23:13:52 -0400 Subject: [PATCH] Log error verifying state --- pkg/auth/oauth/external/handler.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pkg/auth/oauth/external/handler.go b/pkg/auth/oauth/external/handler.go index 3aaaeed4739a..a5e66484446b 100644 --- a/pkg/auth/oauth/external/handler.go +++ b/pkg/auth/oauth/external/handler.go @@ -161,14 +161,14 @@ func (h *Handler) ServeHTTP(w http.ResponseWriter, req *http.Request) { // Validate state before making any server-to-server calls ok, err := h.state.Check(authData.State, req) - if !ok { - glog.V(4).Infof("State is invalid") - err := errors.New("State is invalid") + if err != nil { + glog.V(4).Infof("Error verifying state: %v", err) h.handleError(err, w, req) return } - if err != nil { - glog.V(4).Infof("Error verifying state: %v", err) + if !ok { + glog.V(4).Infof("State is invalid") + err := errors.New("State is invalid") h.handleError(err, w, req) return }