Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Test bootupd #547

Closed
wants to merge 1 commit into from
Closed

Conversation

cgwalters
Copy link
Member

Don't merge.

Don't merge.
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2021
@cgwalters
Copy link
Member Author

/test all

@openshift-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2021
@cgwalters
Copy link
Member Author

One thing I was investigating is whether there was bootupd version drift, but it seems we have 0.2.5 everywhere - and in any case there's not much different between 0.2.4 and 0.2.5 in this respect.

@miabbott
Copy link
Member

miabbott commented May 5, 2021

For the sake of completeness, this is the error we saw in the internal RHCOS pipeline (spotted by @travier)

+ /usr/bin/bootupctl backend generate-update-metadata /
error: file /boot/efi/EFI/BOOT/fbx64.efi: No such file or directory
error: file /boot/efi/EFI/redhat/grubx64.efi: No such file or directory
error: file /boot/efi/EFI/BOOT/BOOTX64.EFI: No such file or directory
error: file /boot/efi/EFI/redhat/shimx64.efi: No such file or directory
error: file /boot/efi/EFI/redhat/mmx64.efi: No such file or directory
error: file /boot/efi/EFI/redhat/shimx64-redhat.efi: No such file or directory
error: file /boot/efi/EFI/redhat/BOOTX64.CSV: No such file or directory
error: generating metadata failed: Failed to invoke rpm -qf
error: bwrap(/usr/bin/rpmostree-postprocess-inline-0): Child process killed by signal 1

@miabbott
Copy link
Member

miabbott commented May 5, 2021

CI job shows the same error noted above

@cgwalters
Copy link
Member Author

OK I verified that using quay.io/coreos-assembler/coreos-assembler:v0.11.0 works. But no idea why yet.

@cgwalters
Copy link
Member Author

Let's land openshift/release#18338 then we'll do a PR here to change our Dockerfile to use it.

cgwalters added a commit to cgwalters/release that referenced this pull request May 5, 2021
@jlebon
Copy link
Member

jlebon commented May 5, 2021

I think the issue might be #548. Something like: base rpm doesn't understand the rpmdb, so rpm -qf gets confused.

@jlebon
Copy link
Member

jlebon commented May 5, 2021

Looking at https://github.com/rpm-software-management/rpm/blob/847c6f062c267c4be643be9c202141bd330a7891/lib/query.c#L466-L478 at least, it does seem like rpm -qf falls back to doing a stat if it can't query the rpmdb and then printing the error message we see in the compose because it can't find the file (which is expected during the treecompose).

@cgwalters
Copy link
Member Author

/retest

@cgwalters
Copy link
Member Author

OK, our CI is working again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants