cluster-launch-installer-e2e: Start setting expirationDate again

[wking]

We'd dropped this in 3f2f01c (#1677). But since openshift/installer@98a35316 (openshift/installer#364), the installer supports setting it again, so we can add it back.

As the name suggests, this variable is not a stable API. Soon the new installer will be able to load the configuration from YAML (again), but we can keep adjusting as the installer evolves.

This pull request also:

• Drops lingering cluster-launch-installer-e2e-smoke references (like remove ref to openshift.yaml aws installer config #1755, cleaning up after ci-operator/config/openshift/installer/master: Move to openshift-install #1677).
• Shifts cluster-launch-installer-e2e.yaml into an openshift/installer subdirectory, where it can have it's own OWNERS.
• Adjusts populate-owners to also populate ci-operator/templates/{org}/{repo}, so we don't have to maintain those by hand.
• Attempt to pull over HTTP, falling back to shallow Git clones if HTTP fails.
• Runs populate-owners again to update our OWNERS files.

Details on any of those in their commit messages.

Fixes #1601 (although I don't go with the "allow caller to only update specific org/repos" approach because of the OWNERS_ALIASES issues discussed in df16e34).

/assign @stevekuznetsov

[stevekuznetsov]

@wking FYI the less green your size/foo label is, the less fun it is to review :)

[stevekuznetsov]

I would prefer these types of independent changes in separate PRs

[wking]

FYI the less green your size/foo label is, the less fun it is to review :) ... I would prefer these types of independent changes in separate PRs

I've spun off two of the early commits into #1768 and #1769. Once #1769 lands, I'll rebase the pull-over-HTTP commits and file a new PR with those. Once that lands, I'll file an new PR with the cluster-launch-installer-e2e move. And once that lands I'll rebase this one to be just the expirationDate restoration. That's my current plan anyway; if you want the commits here split out into different groupings of PRs, let me know :).

[wking]

Ok, once #1792 lands I can rebase this to be just the expirationDate restoration. Orthogonally, at any time after both #1791 and #1792 land we can re-run populate-owners to grant ownership of the new template directory to the installer owners.

[wking]

Ok, #1768, #1769, and #1792 have landed with the bulk of the lead-in work that was initially part of this PR. #1791 is still in flight, but it is largely orthogonal (I'd included it here to help make future changes like expirationDate self-serve for the installer team, but I'm fine leaving it up to the release team in the meantime). So I've just rebased this onto master with just the expirationDate commit (25d83ec -> b20d571).

[stevekuznetsov]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [stevekuznetsov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@wking: Updated the prow-job-cluster-launch-installer-e2e configmap using the following files:

• key cluster-launch-installer-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml

In response to this:

We'd dropped this in 3f2f01c (#1677). But since openshift/installer@98a35316 (openshift/installer#364), the installer supports setting it again, so we can add it back.

As the name suggests, this variable is not a stable API. Soon the new installer will be able to load the configuration from YAML (again), but we can keep adjusting as the installer evolves.

This pull request also:

• Drops lingering cluster-launch-installer-e2e-smoke references (like remove ref to openshift.yaml aws installer config #1755, cleaning up after ci-operator/config/openshift/installer/master: Move to openshift-install #1677).
• Shifts cluster-launch-installer-e2e.yaml into an openshift/installer subdirectory, where it can have it's own OWNERS.
• Adjusts populate-owners to also populate ci-operator/templates/{org}/{repo}, so we don't have to maintain those by hand.
• Attempt to pull over HTTP, falling back to shallow Git clones if HTTP fails.
• Runs populate-owners again to update our OWNERS files.

Details on any of those in their commit messages.

Fixes #1601 (although I don't go with the "allow caller to only update specific org/repos" approach because of the OWNERS_ALIASES issues discussed in df16e34).

/assign @stevekuznetsov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.