Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase memory limits for running openshift-tests #48835

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

jcpowermac
Copy link
Contributor

No description provided.

@jcpowermac
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 15, 2024
@stbenjam
Copy link
Member

Thanks @jcpowermac

  • We can remove vsphere from the title, it appears to affect others

  • Can we add the reasoning to the commit message? Something like:

Increase memory limits for steps running openshift-tests to account for increased memory consumption. This change is necessary due to the removal of a workaround for a Linux kernel bug in golang versions 1.21+. See golang/go#64332.

  • Would you be willing to update some other steps? These reference openshift-tests:
./baremetalds/e2e/test/baremetalds-e2e-test-commands.sh
./baremetalds/sno/test/baremetalds-sno-test-commands.sh
./openshift/e2e/gcp/libvirt/test/openshift-e2e-gcp-libvirt-test-commands.sh
./openshift/e2e/libvirt/test/openshift-e2e-libvirt-test-commands.sh
./openshift/e2e/ovirt/minimal/test/openshift-e2e-ovirt-minimal-test-commands.sh
./openshift/e2e/test/openshift-e2e-test-commands.sh
./single-node/e2e/test/single-node-e2e-test-commands.sh

Increase memory limits for steps running openshift-tests to account for increased memory consumption.
This change is necessary due to the removal of a workaround for a Linux kernel bug in golang versions 1.21+.
See golang/go#64332.
@jcpowermac jcpowermac changed the title vSphere: openshift-test oomkilled;up to 10g Increase memory limits for running openshift-tests Feb 15, 2024
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 15, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jcpowermac: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-jenkins-client-plugin-release-4.9-e2e-aws-jenkins openshift/jenkins-client-plugin presubmit Registry content changed
pull-ci-openshift-jenkins-client-plugin-release-4.8-e2e-aws-jenkins openshift/jenkins-client-plugin presubmit Registry content changed
pull-ci-openshift-jenkins-client-plugin-release-4.7-e2e-aws-jenkins openshift/jenkins-client-plugin presubmit Registry content changed
pull-ci-openshift-jenkins-client-plugin-release-4.6-e2e-aws-jenkins openshift/jenkins-client-plugin presubmit Registry content changed
pull-ci-openshift-jenkins-client-plugin-release-4.5-e2e-aws-jenkins openshift/jenkins-client-plugin presubmit Registry content changed
pull-ci-openshift-jenkins-client-plugin-release-4.4-e2e-aws-jenkins openshift/jenkins-client-plugin presubmit Registry content changed
pull-ci-openshift-jenkins-client-plugin-release-4.3-e2e-aws-jenkins openshift/jenkins-client-plugin presubmit Registry content changed
pull-ci-eclipse-che-che-server-main-v14-gitlab-no-pat-oauth-flow eclipse-che/che-server presubmit Registry content changed
pull-ci-eclipse-che-che-server-main-v14-gitlab-no-pat-oauth-flow-raw-devfile-url eclipse-che/che-server presubmit Registry content changed
pull-ci-eclipse-che-che-server-main-v14-gitlab-no-pat-oauth-flow-ssh-url eclipse-che/che-server presubmit Registry content changed
pull-ci-eclipse-che-che-server-main-v14-bitbucket-no-pat-oauth-flow eclipse-che/che-server presubmit Registry content changed
pull-ci-eclipse-che-che-server-main-v14-bitbucket-no-pat-oauth-flow-raw-devfile-url eclipse-che/che-server presubmit Registry content changed
pull-ci-eclipse-che-che-server-main-v14-bitbucket-no-pat-oauth-flow-ssh-url eclipse-che/che-server presubmit Registry content changed
pull-ci-eclipse-che-che-server-main-v14-github-no-pat-oauth-flow eclipse-che/che-server presubmit Registry content changed
pull-ci-eclipse-che-che-server-main-v14-github-no-pat-oauth-flow-raw-devfile-url eclipse-che/che-server presubmit Registry content changed
pull-ci-eclipse-che-che-server-main-v14-github-no-pat-oauth-flow-ssh-url eclipse-che/che-server presubmit Registry content changed
pull-ci-eclipse-che-che-server-main-v14-github-with-pat-setup-flow eclipse-che/che-server presubmit Registry content changed
pull-ci-eclipse-che-che-server-main-v14-gitlab-with-pat-setup-flow eclipse-che/che-server presubmit Registry content changed
pull-ci-eclipse-che-che-server-main-v14-azure-with-pat-setup-flow eclipse-che/che-server presubmit Registry content changed
pull-ci-eclipse-che-che-server-main-v14-azure-no-pat-oauth-flow eclipse-che/che-server presubmit Registry content changed
pull-ci-eclipse-che-che-server-main-v14-azure-no-pat-oauth-flow-raw-devfile-url eclipse-che/che-server presubmit Registry content changed
pull-ci-eclipse-che-che-server-main-v14-azure-no-pat-oauth-flow-ssh-url eclipse-che/che-server presubmit Registry content changed
pull-ci-eclipse-che-che-server-main-v14-gitea-no-pat-oauth-flow eclipse-che/che-server presubmit Registry content changed
pull-ci-eclipse-che-che-server-main-v14-gitea-with-pat-setup-flow eclipse-che/che-server presubmit Registry content changed
pull-ci-eclipse-che-che-server-main-v14-gitlab-with-oauth-setup-flow eclipse-che/che-server presubmit Registry content changed

A total of 10922 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@stbenjam
Copy link
Member

/pj-rehearse ack
/lgtm

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 15, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2024
Copy link
Contributor

openshift-ci bot commented Feb 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2024
Copy link
Contributor

openshift-ci bot commented Feb 15, 2024

@jcpowermac: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit dec14cc into openshift:master Feb 15, 2024
12 checks passed
mshitrit pushed a commit to mshitrit/release that referenced this pull request Feb 18, 2024
Increase memory limits for steps running openshift-tests to account for increased memory consumption.
This change is necessary due to the removal of a workaround for a Linux kernel bug in golang versions 1.21+.
See golang/go#64332.
shaior pushed a commit to natifridman/release that referenced this pull request Feb 20, 2024
Increase memory limits for steps running openshift-tests to account for increased memory consumption.
This change is necessary due to the removal of a workaround for a Linux kernel bug in golang versions 1.21+.
See golang/go#64332.
sgoveas pushed a commit to sgoveas/release that referenced this pull request Feb 22, 2024
Increase memory limits for steps running openshift-tests to account for increased memory consumption.
This change is necessary due to the removal of a workaround for a Linux kernel bug in golang versions 1.21+.
See golang/go#64332.
memodi pushed a commit to memodi/release that referenced this pull request Mar 14, 2024
Increase memory limits for steps running openshift-tests to account for increased memory consumption.
This change is necessary due to the removal of a workaround for a Linux kernel bug in golang versions 1.21+.
See golang/go#64332.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants